Skip to content

Add missing description label to downstream containerfile [BP]#196

Merged
openshift-merge-bot[bot] merged 1 commit intonetobserv:release-1.8from
msherif1234:fix-cves-1.8
Feb 27, 2025
Merged

Add missing description label to downstream containerfile [BP]#196
openshift-merge-bot[bot] merged 1 commit intonetobserv:release-1.8from
msherif1234:fix-cves-1.8

Conversation

@msherif1234
Copy link
Contributor

Signed-off-by: Mohamed Mahmoud mmahmoud@redhat.com
(cherry picked from commit cebd8d3)

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
(cherry picked from commit cebd8d3)
@msherif1234 msherif1234 requested a review from jotak February 27, 2025 11:19
@codecov
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.53%. Comparing base (79cf57c) to head (b6f571a).
Report is 1 commits behind head on release-1.8.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.8     #196   +/-   ##
============================================
  Coverage        23.53%   23.53%           
============================================
  Files               11       11           
  Lines             1330     1330           
============================================
  Hits               313      313           
  Misses            1000     1000           
  Partials            17       17           
Flag Coverage Δ
unittests 23.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@msherif1234 msherif1234 changed the title add missing description label [BP] Add missing description label to downstream containerfile [BP] Feb 27, 2025
@jotak
Copy link
Member

jotak commented Feb 27, 2025

/lgtm

@msherif1234
Copy link
Contributor Author

/approve

@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 09698a2 into netobserv:release-1.8 Feb 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants