NETOBSERV-2131 allow multiple regexes

[jpinsonneau]

Description

Allow multiple regexes filters to manage cases such as Src OR Dst

Example:

oc netobserv flows --regexes="SrcK8S_Namespace~net1" or --regexes="DstK8S_Namespace~net1"

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.70%. Comparing base (d7dff49) to head (3c52909).
Report is 21 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #207   +/-   ##
=======================================
  Coverage   23.70%   23.70%           
=======================================
  Files          11       11           
  Lines        1333     1333           
=======================================
  Hits          316      316           
  Misses       1000     1000           
  Partials       17       17           

Flag	Coverage Δ
unittests	23.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[memodi]

oc netobserv flows --regexes="SrcK8S_Namespacenet1" or --regexes="DstK8S_Namespacenet1"

@jpinsonneau how many or condition will be supported?

[jpinsonneau]

oc netobserv flows --regexes="SrcK8S_Namespacenet1" or --regexes="DstK8S_Namespacenet1"

@jpinsonneau how many or condition will be supported?

As many as FLP supports which mean unlimited in theory 😎

I think the bottleneck is on perfs as FLP will tests each rule one after the other until one fails:
https://github.com/netobserv/flowlogs-pipeline/blob/main/pkg/pipeline/transform/transform_filter.go#L51-L88
but it's the same on operator side !

[memodi]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-cli:028528b

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=028528b make commands

or download the updated commands.

[memodi]

/label qe-approved

[jotak]

/lgtm

[jpinsonneau]

/retest