NETOBSERV-2113 CLI Integration tests#212
NETOBSERV-2113 CLI Integration tests#212openshift-merge-bot[bot] merged 3 commits intonetobserv:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
==========================================
- Coverage 23.70% 22.30% -1.41%
==========================================
Files 11 13 +2
Lines 1333 1417 +84
==========================================
Hits 316 316
- Misses 1000 1084 +84
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@jpinsonneau any idea why konflux pipelines |
Good question. The go mod tidy / vendor commands doesn't update any file so I think we are good here. |
|
/retest |
|
@OlivierCazade could you please have a look to the konflux error ? 👼 |
|
/retest |
memodi
force-pushed
the
integration-tests
branch
from
9093862 to
b9eda11
Compare
|
/lgtm |
memodi
force-pushed
the
integration-tests
branch
from
79de90c to
0445c30
Compare
|
New changes are detected. LGTM label has been removed. |
|
LGTM |
memodi
force-pushed
the
integration-tests
branch
from
0445c30 to
99b7eb5
Compare
| var flow Flowlog | ||
| for decoder.More() { | ||
| err := decoder.Decode(&flow) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
| if flow.SrcK8sNamespace != nsfilter { | ||
| o.Expect(true).To(o.BeFalse(), fmt.Sprintf("Flow %v does not meet regexes condition SrcK8S_Namespace~%s", flow, nsfilter)) | ||
| } |
There was a problem hiding this comment.
I feel we should decode using a map[string)interface{}) here to avoid keeping the FlowLog definition in the tests
There was a problem hiding this comment.
It will also reduce the dependencies in the go.mod file
There was a problem hiding this comment.
if we use map[string]interface{} then we'd need to do type assertions when we read those fields, correct? that make code bit untidy especially when we need to read in nested structures. wdyt?
There was a problem hiding this comment.
as an alternative, you can declare the type inline with just what you need, such as:
var flow struct {
SrcK8sNamespace string `json:"SrcK8S_Namespace"`
}
|
@jpinsonneau @jotak - any concerns on getting this merged? |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
I'm merging this now. Thanks @memodi ! |
|
/retest |
6 participants
Description
Integration tests for CLI
Dependencies
#201
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.