NETOBSERV-2163 UI rework using tview

[jpinsonneau]

Description

• switch rendering to tview
• support background run
• fix tests
• fix e2e

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

❌ Patch coverage is 19.42605% with 730 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.20%. Comparing base (ef55cef) to head (72c4dae).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/flow_display.go	20.73%	442 Missing and 13 partials ⚠️
e2e/common.go	0.00%	114 Missing ⚠️
cmd/packet_capture.go	0.00%	73 Missing ⚠️
e2e/integration-tests/cli.go	0.00%	42 Missing ⚠️
cmd/flow_capture.go	4.54%	21 Missing ⚠️
cmd/map_format.go	87.09%	6 Missing and 2 partials ⚠️
cmd/mocks.go	0.00%	7 Missing ⚠️
e2e/integration-tests/cluster.go	0.00%	6 Missing ⚠️
cmd/root.go	33.33%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   20.44%   17.20%   -3.24%     
==========================================
  Files          15       15              
  Lines        1629     2133     +504     
==========================================
+ Hits          333      367      +34     
- Misses       1273     1740     +467     
- Partials       23       26       +3     

Flag	Coverage Δ
unittests	17.20% <19.42%> (-3.24%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
cmd/metric_capture.go	0.00% <ø> (ø)
cmd/options.go	25.00% <ø> (ø)
cmd/root.go	26.53% <33.33%> (+1.76%)	⬆️
e2e/integration-tests/cluster.go	0.00% <0.00%> (ø)
cmd/mocks.go	0.00% <0.00%> (ø)
cmd/map_format.go	27.94% <87.09%> (+1.74%)	⬆️
cmd/flow_capture.go	6.79% <4.54%> (+0.60%)	⬆️
e2e/integration-tests/cli.go	0.00% <0.00%> (ø)
cmd/packet_capture.go	0.00% <0.00%> (ø)
e2e/common.go	0.00% <0.00%> (ø)
... and 1 more

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jpinsonneau]

I finally found a way to fix the blinking effect 🥳

The unit tests been simplified to avoid invoking tview but the e2e ones still need some rework here

[github-actions]

New image:
quay.io/netobserv/network-observability-cli:c508381

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=c508381 make commands

or download the updated commands.

[jpinsonneau]

When tview can't display, logs will show the flows: 914060a

That limits a lot the e2e tests so I'll need to figure out if we can test tview properly at some point

[github-actions]

New image:
quay.io/netobserv/network-observability-cli:118348b

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=118348b make commands

or download the updated commands.

[jotak]

/lgtm

[github-actions]

New image:
quay.io/netobserv/network-observability-cli:f7c25d5

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=f7c25d5 make commands

or download the updated commands.

[jpinsonneau]

Rebased and added timeouts to the tests since cmd.Run() wait for process to finish
aa705d0

[jpinsonneau]

@Amoghrd could you please have a look at integrations tests here ?

I have fixed those to support TTY to run the new UI and it works fine locally using kind.

[Amoghrd]

I dont have much idea about those tests, can take a look over the week. If its the pods not coming up it might ImgPull issues for the controller or the collector pods
But if it was running previously and failing now, then something might have broken in this PR or something in konflux such that it cannot pull those images

[OlivierCazade]

LGTM

[Amoghrd]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-cli:a7234b7

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=a7234b7 make commands

or download the updated commands.

[Amoghrd]

/label qe-approved

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment