Update module github.com/onsi/ginkgo/v2 to v2.23.4#267
Update module github.com/onsi/ginkgo/v2 to v2.23.4#267red-hat-konflux[bot] wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
ℹ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a netobserv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
=======================================
Coverage 22.30% 22.30%
=======================================
Files 13 13
Lines 1417 1417
=======================================
Hits 316 316
Misses 1084 1084
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This PR contains the following updates:
v2.23.0->v2.23.4Release Notes
onsi/ginkgo (github.com/onsi/ginkgo/v2)
v2.23.4Compare Source
2.23.4
Prior to this release Ginkgo would compute the incorrect number of available CPUs when running with
-pin a linux container. Thanks to @emirot for the fix!Features
2b9c428]Fixes
1f59d07]Maintenance
2d134d5]v2.23.3Compare Source
2.23.3
Fixes
-as a standalone argument [cfcc1a5]feaf292]88e2282]v2.23.2Compare Source
2.23.2
🎉🎉🎉
At long last, some long-standing performance gaps between
ginkgoandgo testhave been resolved!Ginkgo operates by running
go test -cto generate test binaries, and then running those binaries. It turns out that the compilation step ofgo test -cis slower thango test's compilation step becausego teststrips out debug symbols (ldflags=-w) whereasgo test -cdoes not.Ginkgo now passes the appropriate
ldflagstogo test -cwhen running specs to strip out symbols. This is only done when it is safe to do so and symbols are preferred when profiling is enabled and whenginkgo buildis called explicitly.This, coupled, with the instructions for disabling XProtect on MacOS yields a much better performance experience with Ginkgo.
v2.23.1Compare Source
2.23.1
🚨 For users on MacOS 🚨
A long-standing Ginkgo performance issue on MacOS seems to be due to mac's antimalware XProtect. You can follow the instructions here to disable it in your terminal. Doing so sped up Ginkgo's own test suite from 1m8s to 47s.
Fixes
Ginkgo's CLI is now a bit clearer if you pass flags in incorrectly:
a0e52ff]b799d8d]This might cause existing CI builds to fail. If so then it's likely that your CI build was misconfigured and should be corrected. Open an issue if you need help.
Configuration
📅 Schedule: Branch creation - "after 5am on sunday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.This PR has been generated by MintMaker (powered by Renovate Bot).