NETOBSERV-2243 Add IPsec support to netobserv CLI

[msherif1234]

Description

Add IPsec support to CLI

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[jpinsonneau]

Hey, nice to see you around @msherif1234 👋

This will require a config update, adding the feature in the columns and the graphs in the dashboard for metrics

[msherif1234]

Hey, nice to see you around @msherif1234 👋

This will require a config update, adding the feature in the columns and the graphs in the dashboard for metrics

it seems u have already taken care of the metrics bits Thanks!!

[jpinsonneau]

I'm still getting n/a for now.

I guess we need to bump FLP dependency since it's embedded in eBPF agent here

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.60%. Comparing base (20cf5fd) to head (c91e422).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #286   +/-   ##
=======================================
  Coverage   22.60%   22.60%           
=======================================
  Files          14       14           
  Lines        1451     1451           
=======================================
  Hits          328      328           
  Misses       1099     1099           
  Partials       24       24           

Flag	Coverage Δ
unittests	22.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
cmd/options.go	25.00% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[msherif1234]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-cli:ae5d621

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=ae5d621 make commands

or download the updated commands.

[msherif1234]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-cli:677b419

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=677b419 make commands

or download the updated commands.

[jpinsonneau]

/retest

[jpinsonneau]

The e2e failure is related to #285

I have fixed it in #209 81b9def and cherry picked here

[msherif1234]

/ok-to-test

[msherif1234]

Hi @jpinsonneau can pls check that PR one more time and merge before any other conflicts, not sure if QE wanted to give it a try ?

[github-actions]

New image:
quay.io/netobserv/network-observability-cli:9017911

It will expire after two weeks.

To use this build, update your commands using:

USER=netobserv VERSION=9017911 make commands

or download the updated commands.

[jpinsonneau]

Hey @msherif1234

That's good to me ! Thanks
Let's wait for @memodi / @Amoghrd tests unless we have the go for post merge testing 😉

[memodi]

@jpinsonneau I'll take a look this week if you don't mind waiting.

[memodi]

I verified this, works well. Just minor comment about alphabetical order for the options. thanks @msherif1234

[memodi]

Hi @msherif1234 quick question from UX perspective, currently we report 2 fields/columns - IPSecRetCode an IPSecSuccess - since typically 0 return code translates to true IPSecSuccess - would we lose anything if we consolidate to single field/column say "IPSecSuccess" to have values of true/false/n/a?
Not sure if there could be more than 2 return codes besides 0/1 for IPSecRetCode with different meanings in which case IMO we should enumerate them in code to show them single column alongside true/false

[msherif1234]

Hi @memodi IPsec return code is actually Linux errno values so can be anything but you are right when IPsec success is true the IPsec return code is 0 it's possible in UI to only show IPsec return code where 0 is good and != 0 is bad

[msherif1234]

Hi @jpinsonneau sorry I mistakenly overwrote your commit that fix the e2e can pls readd it and if all good lets merge this Thanks!!

[jpinsonneau]

Hi @jpinsonneau sorry I mistakenly overwrote your commit that fix the e2e can pls readd it and if all good lets merge this Thanks!!

Here we go: 7b58f63

[memodi]

thanks @msherif1234 @jpinsonneau

/label qe-approved

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jpinsonneau]

Konflux failing because of quay outage. Merging