Skip to content

NETOBSERV-2503: allow TLS/mTLS in grpc exporter #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jotak merged 4 commits into from
Dec 5, 2025
Merged

NETOBSERV-2503: allow TLS/mTLS in grpc exporter #843

jotak merged 4 commits into from
Dec 5, 2025

Conversation

@jotak
Copy link
Member

@jotak jotak commented Dec 1, 2025 •
edited
Loading

Description

Add options to configure GRPC exporter with TLS/mTLS

Dependencies

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

To run a perfscale test, comment with: /test ebpf-node-density-heavy-25nodes

@jotak
NETOBSERV-2503: allow TLS/mTLS in grpc exporter
d1dee7d 
Add options to configure GRPC exporter with TLS/mTLS
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 1, 2025 •
edited by openshift-ci bot
Loading

@jotak: This pull request references NETOBSERV-2503 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Description

Add options to configure GRPC exporter with TLS/mTLS

Dependencies

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

To run a perfscale test, comment with: /test ebpf-node-density-heavy-25nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jotak jotak mentioned this pull request Dec 1, 2025
Open
10 tasks
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 1, 2025 •
edited by openshift-ci bot
Loading

@jotak: This pull request references NETOBSERV-2503 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Description

Add options to configure GRPC exporter with TLS/mTLS

Dependencies

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

To run a perfscale test, comment with: /test ebpf-node-density-heavy-25nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jotak jotak mentioned this pull request Dec 1, 2025
Merged
11 tasks
@msherif1234
Copy link
Contributor

msherif1234 commented Dec 1, 2025

Hi @jotak I don't see any test coverage for mTLS case how are u planning on testing it ?

@jotak
Copy link
Member Author

jotak commented Dec 2, 2025

Hi @jotak I don't see any test coverage for mTLS case how are u planning on testing it ?

tests added!
Also on the FLP side, with more coverage: netobserv/flowlogs-pipeline@3da9b4e

@jotak jotak added the needs-review Tells that the PR needs a review label Dec 2, 2025
@msherif1234
Copy link
Contributor

msherif1234 commented Dec 2, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 2, 2025
@openshift-ci
Copy link

openshift-ci bot commented Dec 2, 2025

@jotak: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/netobserv-cli-tests fb6d70d link false /test netobserv-cli-tests
ci/prow/qe-e2e-tests fb6d70d link false /test qe-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jpinsonneau
jpinsonneau approved these changes Dec 4, 2025
View reviewed changes
Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a minor comment on testing

pkg/test/tls.go
Comment on lines 14 to 141
const caCert string = `-----BEGIN CERTIFICATE-----
MIIC+TCCAeGgAwIBAgIULGvHF3aRgJryhvb/9lQMR8TPpIYwDQYJKoZIhvcNAQEL
BQAwDDEKMAgGA1UEAwwBKjAeFw0yMzA4MDIwODUzMTdaFw0zMzA3MzAwODUzMTda
MAwxCjAIBgNVBAMMASowggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDK
NcqKT0leAUzpkmp0x7PYGXvGSXviN7zbo415he1mIYWvuGBhB2J3aUlafABJ2wxD
tdjXFDUI2T9BjRDrbsha4LzhzeBFc3xorlp/KDVZnhgbbHeCL8bfgQrfjsFzAXNa
QEdoTwBRs8fznXVzQ7ecWhobyT9M84v2Mlh93YQFEueiHx0Z8jFUESn6vcOXWXqF
8VZWlPPsRauy79zFkCmr09UKxyOWGtImM+9Sgvda7oZGkJBZ1gvhBULOG72ekhsH
RtlT4Xmf4irINm4vRnZcFRJgwaOsCvX/9gyDCfoJ0ioUZ5ZmhYNGJeNSi63LnAZm
1Zsa4ZOGvtdsdAgaZN1jAgMBAAGjUzBRMB0GA1UdDgQWBBQ34SoDX/LC+i2h57cI
aOGmGZTgBzAfBgNVHSMEGDAWgBQ34SoDX/LC+i2h57cIaOGmGZTgBzAPBgNVHRMB
Af8EBTADAQH/MA0GCSqGSIb3DQEBCwUAA4IBAQBfFSuPYJK0Gt8psgARSHLJUzSB
X9XmcIYpeFIZk5GqmGnj/0op4w3R/T/TwYTf7+FvqGIKaMyXSgeJJu1uC1M/AI11
nQmv9XtLmX2BJtKWORoBOPYKnoGSaljoQJZzJJ09lzasHLy68cYezbqb+3+EIGEa
vBKdFgbDyYQpSIs3oAIW9drcEywFf8s5ZSewPhaz1byDlvTHJjKNGoWwm/tlXhv/
GXHWiYftbJRGHDiA9BqZT2g/vMz/1e9k5wSek+fqaBQNS7nEijUz+Qk0LlmagZV3
kom8Fkz5HTYkmZVzXPW8spFEuIibCgRK1qA1RuDsyNxMnk3c1jcR8B5AJ/VI
-----END CERTIFICATE-----`

// Client key (for mTLS) generated with:
// openssl req -newkey rsa:2048 -nodes -keyout client.key -out client.csr -subj "/C=GB/ST=London/L=London/O=libvault consultants/OU=IT Department/CN=*"
const clientKey string = `-----BEGIN PRIVATE KEY-----
MIIEvQIBADANBgkqhkiG9w0BAQEFAASCBKcwggSjAgEAAoIBAQC6MwSpGNZz7sCO
/6Wn+iC7Am+UxQkfm+SWHDxRB9wgDQbZVesAFWiRkMXcTQjBc/71R2RhZed1FFVO
vXZfewfgepdq9RlRCEgFSoMhF8zuwxwKfrrAML2PiRy720i0azwLLilTQB9s5MrB
Cz0Gsq2neY6wXf3KkyMYyhzBaKocl5NqxIcHILWJ+jBnKrfvW69CP8jtIjZLo9xS
WtCw0S2pTVRBt16smiA8VNfXnZc2p8LyWCmZ523AjqKnatviiJ6apyTlhsLMx9Lf
RIqkirgaoTB9y6VFvyZQtqXD+PI7r9QykVgHioMnep2gsJwgxqTuj75gxTsebIJd
PKdv4qwTAgMBAAECggEAUSsWWAR8z/L/PBcThsNR61PngknWbVIO9qT+YjBz9ADZ
wHpkxBeRCwu6RQvLylEfjpr9ljvPB0nC2l1bMco3J9MpGLYZwCpFAxF1UkLG0jp5
idWu4UMeD2ks/nNcIVIxzYnk9+aXDGg8PqUAiF/xtXUXD6kZjmpPvWm12VYf+fAX
OIXrs3BDJKsJUDfOxg8ujcOuK+qyQjVOoiR8zrREZy/fCRc0TSD7tnnLLPW5MCst
PaFhS8vb35XuTvzCW7yCdosV/xnf2I22KWVJDxV11xtfbi3AF8ggyzUZElW8fVCz
7AJU3W95NVArNw3mvSm6vTcdbddQbuJsMnW1Hc2YCQKBgQDaBUlnliOpTUAGxCOV
sLl7GjsMfH8TrsHa9+ca0BwcoSqDky0jGh/sm1LgyPqoHn9Vj8uK/DLebNMnRZAc
KzGMQpzneW7K0G64SHJI6Faa29FTUfa+azeS3vIKa6WbTWzuhGQ/R7OqTy7UbJTs
IQaA/vfPa13ZNWtHONAaMO96PQKBgQDaoqVVv9NZIVCK1PlcdHhjJ++NrWkKgBGk
YaMvXbWRP0vF1vEgKIE8vzNufQiw6FuiZgeLQluglN6wkvV3fzhVnu7An8DqVaxD
JQQAuwHTvn3wmiepMuYNleYU67bAeFhNZRJuOmkUtrLiPOgVliuwNUqmaaUnzouD
RLzFs/00jwKBgQCLcqI2zUNWAIEZUs7n6bdZU7e9DsxBDKAVrEZ3UfEJJtSIf9R5
BTayIc7q0+HvMkKDuYuZBCKNPdH45nd8bOwuKFUvgO4qbxLCcCQZGfJ67mp+/ofx
16YeHNd3bs7n/KfWD3wHNZdnMWpkmGbQeXctfueGFchbK93IGkCQ4AfsiQKBgHEH
bsRC9Gd6wqHTcsrqZ6aTadPr14cXKIe79loxbwGVIH46HdRLPG0ER/mR6GFU7rKp
XrMO7kG5VNsiToalnaEeFj49GMXM3s6jn0slYs9uBrvRZjmh168kVJtyNLuSO8xf
OUUFK3gK77XoWO94AEQLePlJWpmWvSdy7MikwX1fAoGALrRIZVmlmDoJ/jm9lNaZ
r3PmRWYlhqLyI/oeEzczqy6WOGcTOQsXlP4Yu1EM6V9mLqQ4ATZ2lUM3mcahfi14
RPYzuPxqdxxmRGy1iPVWwU7Jw97ke80Zx68Wm69sQHb8Gz9Y6B3c/F63WMuojyas
APnsbr5Kx+5wC0t3xGfShK4=
-----END PRIVATE KEY-----`

// Client cert (for mTLS) generated with:
// openssl x509 -req -days 3650 -sha256 -in client.csr -CA ca.crt -CAkey ca.key -CAcreateserial -out client.crt -extfile <(echo subjectAltName = IP:127.0.0.1)
const clientCert string = `-----BEGIN CERTIFICATE-----
MIIDXzCCAkegAwIBAgIUZP3uzJrPArjETkLd2SZticeIAeMwDQYJKoZIhvcNAQEL
BQAwDDEKMAgGA1UEAwwBKjAeFw0yMzA4MDIwODU1NTJaFw0zMzA3MzAwODU1NTJa
MHIxCzAJBgNVBAYTAkdCMQ8wDQYDVQQIDAZMb25kb24xDzANBgNVBAcMBkxvbmRv
bjEdMBsGA1UECgwUbGlidmF1bHQgY29uc3VsdGFudHMxFjAUBgNVBAsMDUlUIERl
cGFydG1lbnQxCjAIBgNVBAMMASowggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEK
AoIBAQC6MwSpGNZz7sCO/6Wn+iC7Am+UxQkfm+SWHDxRB9wgDQbZVesAFWiRkMXc
TQjBc/71R2RhZed1FFVOvXZfewfgepdq9RlRCEgFSoMhF8zuwxwKfrrAML2PiRy7
20i0azwLLilTQB9s5MrBCz0Gsq2neY6wXf3KkyMYyhzBaKocl5NqxIcHILWJ+jBn
KrfvW69CP8jtIjZLo9xSWtCw0S2pTVRBt16smiA8VNfXnZc2p8LyWCmZ523AjqKn
atviiJ6apyTlhsLMx9LfRIqkirgaoTB9y6VFvyZQtqXD+PI7r9QykVgHioMnep2g
sJwgxqTuj75gxTsebIJdPKdv4qwTAgMBAAGjUzBRMA8GA1UdEQQIMAaHBH8AAAEw
HQYDVR0OBBYEFJXWoxXktt1SPSppKKxG9irVdZ6pMB8GA1UdIwQYMBaAFDfhKgNf
8sL6LaHntwho4aYZlOAHMA0GCSqGSIb3DQEBCwUAA4IBAQAY+8cforOMMqzuyQtm
q2fs+rd/AavSTxxOjazD+QX7vwoCjvSqBSVr53//1hFKoEE33PsQ+UpNVOkYyNo1
QuyKfhlnqJ7wfXYFWorU07qjHHc02SlQmqHTIpu0VaUxRuEbHdMhO54oJqBnLkL5
lSOGjsHAMVh/a7ET96OqZKwMwNpWZXLmVhkXkpqf21Ept8P1aweEmmkaW3WAMQ/Y
L99WlvK/Zds/xUlXcpDBOrVZwXuYqhYsjxfig5J6z3bX6o/0g+baL0CRpIz+66BF
Ks1CJYZnOX9Tb26DyBTQAUXzJMv9sJXlYF3Llhd14YfEmOeXnNkog8GflJA7GU6C
lkAS
-----END CERTIFICATE-----`

// Server key generated with:
// openssl req -newkey rsa:2048 -nodes -keyout server.key -out server.csr -subj "/C=GB/ST=London/L=London/O=libvault consultants/OU=IT Department/CN=*"
const serverKey string = `-----BEGIN PRIVATE KEY-----
MIIEvAIBADANBgkqhkiG9w0BAQEFAASCBKYwggSiAgEAAoIBAQClYidsRfhbhwxx
GUZ7X7/CwltfZCof/FmrYqzsWzimr8tUWPy/AHJHo+A08ixuZMBuCn2Uh22gFaEZ
Kn3Uk8ZmGXb9IhYZxTJrYx9+ZUvBaN5g8072bbF2TCCDYhX1w9o488mSVe3vP/I/
tINuOy990fr1BkhzSoFD/xVhQMqoDN00+B8mIWJ9pstknDcAM+6Z+FfUuwzLcxx5
LogpOIGhYt+03ywXDxfuvXfRFXFGCwifcLx8XyiOchBckxLtfXioC4Q61gWE63VN
J7qyPDrdUZ/CCY5Vz+qRqsF2rlwOWPluXrWzaKzlvmCm5iQ8J58c6dHhyY8Yob8K
xHo9F56bAgMBAAECggEARgN6Hg+3FwRio4SoPnWoCErghM8yOC1MRs5013C82HAm
m5Q6l5+YQbTiJ3f4kFmNz2gYhucYZUOS2kUPVQ2kWbfhFEO4aHt/n0+s1wUKH5yG
PDP000VX8fVDdGtzUYJy4VZvmMhQ/M6s/wQr+eALeHALFmztAgXiGIemJPBZeu+c
rbAFowzdYsHpTSrh2nm0HYSoyZr87wQoQjLo0c6FqLLxYcnCvMemcg8HK4iw6I0a
vbbG61Pdg4CNy6ZgSS96+WwiixrcWoQ7CN339giRmFT2e6vulbreQtD4QzlmqtWW
su+Du3kc/9XqtJwOpyOkHyXrALMnpPC+c0WnVp76xQKBgQDa/kd79kOWzQXTKmqn
heuaKq/UTMYlGhc13KhEpXeX/r0skWMKjuvxgVacNxv4F4d2axCLmADh1UotZsDz
9Hlvq5aPn8f/VYv0CCwOrigSyv25AEAZCnk84igbiSq1TfXppJzyqYoLue2HrW4k
CHL9KviBwauePNRDv+KNZJGALQKBgQDBVLHMDF6xjsy27T4toqLz1thdiBjd/GR+
SE6+j18z/CKJVCWlRBykmJ3vxW9qAptdb86ZxmfIFnkWJTt/yEthvyfqHe6ksXED
SElOKuReUYAPJazaGS5F9TywGnsVxhwn9BtqPMy/b7WRQJowcG9zSlntjT+cn7sg
GfSB6ASO5wKBgDaiRXc5ovcWQyPBa0ZL9NFLYP5YAP70mWHIoPovRbzXwp5BzzGt
IlPn7pGedg3Y4OS8JS6OR3oP2ielgPHbxggECNXgCOc8kmPZPhSTgk/d8Jqc42Db
6g80ZMkp2UvOHVGizb0Eavot8oJs1BONQBLFC6ZjiMs7ZcFZN84KjvopAoGAYPAz
ummVbZh5o1tv6vf6lyNqF/Pu7Bfq17sv6LMA/JL3Sj6sJaLybcGsp5Yq2E/4UTCH
umlWjmheTLFclST8T0XHIMfjaici0I+FWjF9kqFxAadVdYJcxm1CAdc1UmSkp4/p
0yorS+4ab3uiFJm7+GYWk1tYwxMAhAcfp6eL6Y8CgYAMNptHbD/fL0wrXDBVWRYP
LL55dHKf6Op+c2N9/82WsaMpHQ/A8MiIn2iwQReEIjl0zk+OfvTgQEz1FEw+zZk/
kFWRLF8Hel5mv0JKz8ExZ4LHTTE8OpxvEbvP3j6A/MngpsuN73LA4i/GqrktGtiy
UYF0gdXCSiPfvXct5lwU7g==
-----END PRIVATE KEY-----`

// Server cert generated with:
// openssl x509 -req -days 3650 -sha256 -in server.csr -CA ca.crt -CAkey ca.key -CAcreateserial -out server.crt -extfile <(echo subjectAltName = IP:127.0.0.1)
const serverCert string = `-----BEGIN CERTIFICATE-----
MIIDXzCCAkegAwIBAgIUZGbRxIm/HK0OiVdTzIFWmnPqttUwDQYJKoZIhvcNAQEL
BQAwDDEKMAgGA1UEAwwBKjAeFw0yMzA4MDIwODU0NTlaFw0zMzA3MzAwODU0NTla
MHIxCzAJBgNVBAYTAkdCMQ8wDQYDVQQIDAZMb25kb24xDzANBgNVBAcMBkxvbmRv
bjEdMBsGA1UECgwUbGlidmF1bHQgY29uc3VsdGFudHMxFjAUBgNVBAsMDUlUIERl
cGFydG1lbnQxCjAIBgNVBAMMASowggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEK
AoIBAQClYidsRfhbhwxxGUZ7X7/CwltfZCof/FmrYqzsWzimr8tUWPy/AHJHo+A0
8ixuZMBuCn2Uh22gFaEZKn3Uk8ZmGXb9IhYZxTJrYx9+ZUvBaN5g8072bbF2TCCD
YhX1w9o488mSVe3vP/I/tINuOy990fr1BkhzSoFD/xVhQMqoDN00+B8mIWJ9pstk
nDcAM+6Z+FfUuwzLcxx5LogpOIGhYt+03ywXDxfuvXfRFXFGCwifcLx8XyiOchBc
kxLtfXioC4Q61gWE63VNJ7qyPDrdUZ/CCY5Vz+qRqsF2rlwOWPluXrWzaKzlvmCm
5iQ8J58c6dHhyY8Yob8KxHo9F56bAgMBAAGjUzBRMA8GA1UdEQQIMAaHBH8AAAEw
HQYDVR0OBBYEFOdbqIlktmQGpRr9ydKkACwx/OnhMB8GA1UdIwQYMBaAFDfhKgNf
8sL6LaHntwho4aYZlOAHMA0GCSqGSIb3DQEBCwUAA4IBAQAMKfFetofRb9dFInU5
KpF3+IVwrR53UbUbNF0mnQ7aNRE7YfLPRTOV2Dp5zeOlUiO6FhK1AkCcs1RILzUM
bUwolEbgQRmMV8NPyY+0vkBQDJQYfw3bHm2NCWRKd2A0KI9rX1VpWvY3Z300zmLM
TPgRGwN4oZbQLpbI6iZ+MuaBw9c3xOuVKGI0OQybl7MM49Uk/QAf+Ltb+VD/b+NR
QtOnsqqqb3s8LlqTbYn1zM9FSX2YNRljDkElTVfzhlD2qpMvy8Ep8qrAlFcI8yZ8
HKUIvMe6pjPWHHGVkKBldRqQIOH5WoUSKjrC8koV+Kqj6PMXKquyZdvdC3bhgj4l
Pnib
-----END CERTIFICATE-----`
Copy link
Contributor

@jpinsonneau jpinsonneau Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also try with an invalid cert ?

Copy link
Member Author

@jotak jotak Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, I've added a test where the client certificate is signed by an authority unknown from the server

@openshift-ci openshift-ci bot removed the lgtm label Dec 5, 2025
@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak added ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. and removed needs-review Tells that the PR needs a review labels Dec 5, 2025
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

New images:
quay.io/netobserv/ebpf-bytecode:7c273c8
quay.io/netobserv/netobserv-ebpf-agent:7c273c8

These will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=7c273c8 make set-agent-image

@jotak jotak merged commit d2330a5 into netobserv:main Dec 5, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpinsonneau jpinsonneau jpinsonneau approved these changes

@msherif1234 msherif1234 Awaiting requested review from msherif1234

@leandroberetta leandroberetta Awaiting requested review from leandroberetta

@OlivierCazade OlivierCazade Awaiting requested review from OlivierCazade

Assignees

@msherif1234 msherif1234

@jpinsonneau jpinsonneau

Labels

jira/valid-reference ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jotak @openshift-ci-robot @msherif1234 @jpinsonneau