-
Notifications
You must be signed in to change notification settings - Fork 16
Upgrade linter + refactor display loops #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Replace all big switches with some (hopefully) simpler mechanism that loops forward/backward by inc/decrementing an index in a more structured definition
|
(second commit was sort of related to the linter upgrade, since I had to refactor all those big if/else chains for display loops into switches, I'm thinking it can be refactored even further) |
353535c to
67a98d7
Compare
67a98d7 to
27b52da
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
+ Coverage 26.00% 26.20% +0.19%
==========================================
Files 8 9 +1
Lines 1315 1225 -90
==========================================
- Hits 342 321 -21
+ Misses 952 888 -64
+ Partials 21 16 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
oh I forgot @jpinsonneau you did a similar thing in #105 for looping through display modes :( |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Upgrading linter showed some potential actual bugs during cleanup / exit, where deferred functions aren't called when something like
log.Fataloros.Exitis called, so I had to move things around to fix that (basically: having functions returning errors in case of doing something Fatal, and dealing with fatality in caller)