NETOBSERV-2435 fix background mode and update doc#395
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| return toFloat64(lastFlows[i], "Time") < toFloat64(lastFlows[j], "Time") | ||
| }) | ||
| // lock since we are updating lastFlows concurrently | ||
| mutex.Lock() |
There was a problem hiding this comment.
would be safer / best practice to have defer Unlock here ?
defer mutex.Unlock()
There was a problem hiding this comment.
Sure, I can address that in parallel if it's ok for you
That code was already there and not related to that fix
jotak
left a comment
There was a problem hiding this comment.
/lgtm
just a nice-to-have comment
|
/ok-to-test |
|
New image: It will expire after two weeks. To use this build, update your commands using: USER=netobserv VERSION=f3fe30a make commands |
|
/label qe-approved |
|
@jpinsonneau: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Example after running
$ oc netobserv metrics --background:Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.