-
Notifications
You must be signed in to change notification settings - Fork 22
chore(KONFLUX-6210): fix and set name and cpe label for network-observability-console-plugin-pf4-zstream #1026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…vability-console-plugin-pf4-zstream For https://issues.redhat.com/browse/KONFLUX-6210, clair needs access to a name and cpe label that it can use to look up the image in VEX statements. See also release-engineering/rhtap-ec-policy#149 Signed-off-by: Ralph Bean <[email protected]> Assisted-by: Gemini
Hi @ralphbean. Thanks for your PR. I'm waiting for a netobserv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @ralphbean , thanks for your PR. I've added a commit to pass it as an arg, which is more consistent with our workflow. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.9-pf4 #1026 +/- ##
================================================
Coverage 56.81% 56.81%
================================================
Files 196 196
Lines 10204 10204
Branches 1186 1186
================================================
Hits 5797 5797
Misses 4043 4043
Partials 364 364
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=9b2f0c2 make set-plugin-image |
/ok-to-test |
4b02f8b
into
netobserv:release-1.9-pf4
For https://issues.redhat.com/browse/KONFLUX-6210, clair needs access to a name and cpe label that it can use to look up the image in VEX statements.
See also release-engineering/rhtap-ec-policy#149
Signed-off-by: Ralph Bean [email protected]
Assisted-by: Gemini