Skip to content

NETOBSERV-2355: Rename sampling ratio/rate -> interval #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

NETOBSERV-2355: Rename sampling ratio/rate -> interval #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/sample-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1463,7 +1463,7 @@ frontend:
description: Differentiated Services Code Point (DSCP) value
- name: Sampling
type: number
description: Sampling rate used for this flow
description: Sampling interval used for this flow
- name: IcmpType
type: number
description: ICMP type
Expand Down
12 changes: 6 additions & 6 deletions web/moduleMapper/schemas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ export const FlowCollectorSchema: RJSFSchema | any = {
properties: {
sampling: {
description:
'Sampling rate of the flow reporter. 100 means one flow on 100 is sent. 0 or 1 means all flows are sampled.',
'Sampling interval of the flow reporter. 100 means one flow on 100 is sent. 0 or 1 means all flows are sampled.',
type: 'integer',
format: 'int32',
default: 50,
Expand Down Expand Up @@ -274,7 +274,7 @@ export const FlowCollectorSchema: RJSFSchema | any = {
},
sampling: {
description:
'`sampling` sampling rate for the matched flows, overriding the global sampling defined at `spec.agent.ebpf.sampling`.',
'`sampling` sampling interval for the matched flows, overriding the global sampling defined at `spec.agent.ebpf.sampling`.',
type: 'integer',
format: 'int32'
},
Expand Down Expand Up @@ -366,7 +366,7 @@ export const FlowCollectorSchema: RJSFSchema | any = {
},
sampling: {
description:
'`sampling` sampling rate for the matched flows, overriding the global sampling defined at `spec.agent.ebpf.sampling`.',
'`sampling` sampling interval for the matched flows, overriding the global sampling defined at `spec.agent.ebpf.sampling`.',
type: 'integer',
format: 'int32'
},
Expand Down Expand Up @@ -1648,7 +1648,7 @@ export const FlowCollectorSchema: RJSFSchema | any = {
},
sampling: {
description:
'`sampling` is the sampling rate on the reporter. 100 means one flow on 100 is sent.\nTo ensure cluster stability, it is not possible to set a value below 2.\nIf you really want to sample every packet, which might impact the cluster stability,\nrefer to `forceSampleAll`. Alternatively, you can use the eBPF Agent instead of IPFIX.',
'`sampling` is the sampling interval on the reporter. 100 means one flow on 100 is sent.\nTo ensure cluster stability, it is not possible to set a value below 2.\nIf you really want to sample every packet, which might impact the cluster stability,\nrefer to `forceSampleAll`. Alternatively, you can use the eBPF Agent instead of IPFIX.',
type: 'integer',
format: 'int32',
default: 400,
Expand Down Expand Up @@ -2875,7 +2875,7 @@ export const FlowCollectorSchema: RJSFSchema | any = {
enum: ['Disabled', 'Drop', 'Sample']
},
sampling: {
description: '`sampling` is the sampling rate when deduper `mode` is `Sample`.',
description: '`sampling` is the sampling interval when deduper `mode` is `Sample`.',
type: 'integer',
format: 'int32',
default: 50,
Expand Down Expand Up @@ -3380,7 +3380,7 @@ export const FlowCollectorSchema: RJSFSchema | any = {
enum: ['', 'Loki', 'Metrics', 'Exporters']
},
sampling: {
description: '`sampling` is an optional sampling rate to apply to this filter.',
description: '`sampling` is an optional sampling interval to apply to this filter.',
type: 'integer',
format: 'int32',
minimum: 0
Expand Down