Skip to content

Static plugin UX: use pre text, etc. Fix error on missing order field #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Static plugin UX: use pre text, etc. Fix error on missing order field #1038

wants to merge 2 commits into from

Conversation

jotak
Copy link
Member

@jotak jotak commented Sep 22, 2025 •
edited
Loading

Description

  • Fix error on missing alerts field
  • Replace backticks with "pre" tags
  • More explicit text to signal shortened text can be clicked
  • Use '*' in all order fields to avoid crashes when a new field is added

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@jotak jotak requested a review from jpinsonneau September 22, 2025 17:22
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jotak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak changed the title Static plugin UX: use pre text, etc. Static plugin UX: use pre text, etc. Fix error on missing order field Sep 22, 2025
@jotak jotak added the needs-review Tells that the PR needs a review label Sep 23, 2025
jpinsonneau
jpinsonneau reviewed Sep 23, 2025
View reviewed changes
web/src/components/forms/config/uiSchema.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you missed some ui:order such as in processor 🤔 was that on purepose ?

Maybe to avoid that we could simply append the '*' programatically while loading the UISchema ?

jpinsonneau
jpinsonneau reviewed Sep 23, 2025
View reviewed changes
web/src/components/forms/dynamic-form/fields.tsx
>
<Button className={`co-pre-line description`} variant="plain" style={{ paddingLeft: 0 }}>
{`${parts[0]}...`}
{formatText(parts[0])} {t('(see more...)')}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about that (see more...) text here.

Patternfly uses ellipsis:
https://v5-archive.patternfly.org/ux-writing/truncation
https://v5-archive.patternfly.org/components/truncate

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 23, 2025

@jotak: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/plugin-cypress 7c83746 link true /test plugin-cypress
ci/prow/qe-e2e-console-tests 7c83746 link false /test qe-e2e-console-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jotak
Copy link
Member Author

jotak commented Sep 23, 2025

commit was merged into #1028

@jotak jotak closed this Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpinsonneau jpinsonneau jpinsonneau left review comments

Assignees

No one assigned

Labels

needs-review Tells that the PR needs a review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jotak @jpinsonneau