Skip to content

NETOBSERV-2429: add UI schema for consumer replicas #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2025
Merged

NETOBSERV-2429: add UI schema for consumer replicas #1111

merged 1 commit into from
Nov 14, 2025

Conversation

@jotak
Copy link
Member

@jotak jotak commented Nov 10, 2025

Description

  • Add unmanagedReplicas / consumerReplicas
  • Hide autoscalers & deprecated settings
  • Some reordering in processor schema
  • Add a note in README describing what should be done when updating CRDs

Dependencies

Operator: netobserv/network-observability-operator#1953

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 10, 2025 •
edited by openshift-ci bot
Loading

@jotak: This pull request references NETOBSERV-2429 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Description

  • Add unmanagedReplicas / consumerReplicas
  • Hide autoscalers & deprecated settings
  • Some reordering in processor schema
  • Add a note in README describing what should be done when updating CRDs

Dependencies

Operator: netobserv/network-observability-operator#1953

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Nov 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mariomac for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak mentioned this pull request Nov 10, 2025
Merged
10 tasks
@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 10, 2025
@github-actions
Copy link

github-actions bot commented Nov 10, 2025

New image:
quay.io/netobserv/network-observability-console-plugin:faaa773

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=faaa773 make set-plugin-image

@jotak
NETOBSERV-2429: add UI schema for consumer replicas
73f10c8 
- Add unmanagedReplicas / consumerReplicas
- Hide autoscalers & deprecated settings
- Some reordering in processor schema
- Add a note in README describing what should be done when updating CRDs
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 10, 2025
@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 10, 2025
@github-actions
Copy link

github-actions bot commented Nov 10, 2025

New image:
quay.io/netobserv/network-observability-console-plugin:75a2eec

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=75a2eec make set-plugin-image

@openshift-ci
Copy link

openshift-ci bot commented Nov 10, 2025

@jotak: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/qe-e2e-console-tests 73f10c8 link false /test qe-e2e-console-tests
ci/prow/images 73f10c8 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

OlivierCazade
OlivierCazade approved these changes Nov 14, 2025
View reviewed changes
Copy link
Collaborator

@OlivierCazade OlivierCazade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Nov 14, 2025
@jotak jotak merged commit a168308 into netobserv:main Nov 14, 2025
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OlivierCazade OlivierCazade OlivierCazade approved these changes

@leandroberetta leandroberetta Awaiting requested review from leandroberetta

@jpinsonneau jpinsonneau Awaiting requested review from jpinsonneau

Assignees

@OlivierCazade OlivierCazade

Labels

jira/valid-reference lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jotak @openshift-ci-robot @OlivierCazade