Skip to content

Conversation

jpinsonneau
Copy link
Contributor

Description

Invalidate local storage values when necessary:

  • record type
  • datasource
  • packet loss
  • metric scope / group
  • metric type / function

Columns / panels should not be impacted as already working properly.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link

openshift-ci bot commented Sep 10, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 25 lines in your changes missing coverage. Please review.

Project coverage is 56.29%. Comparing base (48d9fbf) to head (51196a2).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
web/src/components/netflow-traffic.tsx 43.47% 10 Missing and 3 partials ⚠️
web/src/model/netflow-traffic.ts 33.33% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #594   +/-   ##
=======================================
  Coverage   56.29%   56.29%           
=======================================
  Files         190      190           
  Lines        9289     9304   +15     
  Branches     1197     1200    +3     
=======================================
+ Hits         5229     5238    +9     
- Misses       3691     3694    +3     
- Partials      369      372    +3     
Flag Coverage Δ
uitests 57.82% <44.44%> (+<0.01%) ⬆️
unittests 52.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../src/components/dropdowns/metric-type-dropdown.tsx 75.00% <100.00%> (+13.23%) ⬆️
...components/dropdowns/topology-display-dropdown.tsx 66.66% <ø> (ø)
.../components/dropdowns/topology-display-options.tsx 46.66% <ø> (ø)
...c/components/tabs/netflow-overview/panel-kebab.tsx 62.16% <ø> (ø)
...eb/src/components/toolbar/view-options-toolbar.tsx 18.96% <ø> (ø)
web/src/utils/router.ts 82.29% <100.00%> (+0.57%) ⬆️
web/src/model/netflow-traffic.ts 83.78% <33.33%> (-16.22%) ⬇️
web/src/components/netflow-traffic.tsx 68.75% <43.47%> (+0.25%) ⬆️

@Amoghrd
Copy link
Member

Amoghrd commented Sep 18, 2024

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 18, 2024
Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:aa87a0f

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=aa87a0f make set-plugin-image

@Amoghrd
Copy link
Member

Amoghrd commented Sep 18, 2024

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Sep 18, 2024
@jpinsonneau
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit eb746d5 into netobserv:main Sep 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants