Addressing konflux error and fixing multi arch build with podman 5.2 #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierCazade
force-pushed
the
konflux-violations
branch
2 times, most recently
from
be1cea0 to
a78cc16
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #595 +/- ##
=======================================
Coverage 56.01% 56.01%
=======================================
Files 193 193
Lines 9479 9479
Branches 1213 1213
=======================================
Hits 5310 5310
Misses 3792 3792
Partials 377 377
Flags with carried forward coverage won't be shown. Click here to find out more. |
OlivierCazade
force-pushed
the
konflux-violations
branch
2 times, most recently
from
bb838aa to
36e0bc8
Compare
jotak
approved these changes
Sep 16, 2024
OlivierCazade
force-pushed
the
konflux-violations
branch
from
36e0bc8 to
0e5aa74
Compare
OlivierCazade
force-pushed
the
konflux-violations
branch
19 times, most recently
from
4e8eca3 to
1aea045
Compare
OlivierCazade
force-pushed
the
konflux-violations
branch
8 times, most recently
from
a76ba3c to
f833039
Compare
OlivierCazade
force-pushed
the
konflux-violations
branch
from
f833039 to
fed9beb
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: OlivierCazade The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
OlivierCazade
added a commit
to OlivierCazade/network-observability-console-plugin
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing multiarch build.
Addressing multiple konflux error:
- the build not being hermetic
- removing deprecated task in the build
- using base image from registry.redhat.io