Skip to content

Conversation

jotak
Copy link
Member

@jotak jotak commented Sep 16, 2024

same as netobserv/network-observability-operator#769 , with some extra cleaning

@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Sep 16, 2024
@jotak jotak requested a review from OlivierCazade September 16, 2024 13:39
Copy link

openshift-ci bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.28%. Comparing base (f8abad2) to head (a0f65b4).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (f8abad2) and HEAD (a0f65b4). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f8abad2) HEAD (a0f65b4)
uitests 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
- Coverage   55.35%   50.28%   -5.07%     
==========================================
  Files         193       37     -156     
  Lines       10098     3130    -6968     
  Branches     1218        0    -1218     
==========================================
- Hits         5590     1574    -4016     
+ Misses       4131     1392    -2739     
+ Partials      377      164     -213     
Flag Coverage Δ
uitests ?
unittests 50.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 156 files with indirect coverage changes

@jotak
Copy link
Member Author

jotak commented Oct 4, 2024

@OlivierCazade I rebased this PR, you already fixed the initial problem but this is still doing a bit a cleanup (removing unused arguments)

@jotak jotak changed the title fix podman builds Dockerfile cleanup: remove unused args Nov 14, 2024
@jotak jotak merged commit dfe4f95 into netobserv:main Nov 14, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants