Skip to content

Conversation

jpinsonneau
Copy link
Contributor

Description

  • add cypress tests on fields
  • fixed icmp 0 values
  • updated config sample

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@jpinsonneau
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot added the lgtm label Oct 8, 2024
@openshift-ci openshift-ci bot removed the lgtm label Nov 5, 2024
Copy link

openshift-ci bot commented Nov 5, 2024

New changes are detected. LGTM label has been removed.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.83%. Comparing base (01883f0) to head (f98acd1).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
pkg/config/config.go 0.00% 1 Missing ⚠️
web/src/utils/icmp.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #604      +/-   ##
==========================================
+ Coverage   56.70%   56.83%   +0.12%     
==========================================
  Files         197      197              
  Lines       10113    10146      +33     
  Branches     1192     1192              
==========================================
+ Hits         5735     5766      +31     
- Misses       4009     4012       +3     
+ Partials      369      368       -1     
Flag Coverage Δ
uitests 59.22% <0.00%> (ø)
unittests 51.71% <0.00%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...omponents/tabs/netflow-table/netflow-table-row.tsx 91.66% <ø> (ø)
...rc/components/tabs/netflow-table/netflow-table.tsx 58.82% <ø> (ø)
web/src/model/config.ts 100.00% <ø> (ø)
pkg/config/config.go 43.50% <0.00%> (-0.29%) ⬇️
web/src/utils/icmp.ts 57.40% <0.00%> (ø)

... and 2 files with indirect coverage changes

@Amoghrd
Copy link
Member

Amoghrd commented Nov 22, 2024

/label no-qe
Adding no-qe label since PR description mentions the same

@openshift-ci openshift-ci bot added the no-qe This PR doesn't necessitate QE approval label Nov 22, 2024
@jpinsonneau
Copy link
Contributor Author

rebased without changes

Copy link

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Dec 9, 2024
Copy link

openshift-ci bot commented Dec 9, 2024

New changes are detected. LGTM label has been removed.

@jpinsonneau
Copy link
Contributor Author

had to update sample config since #633 broke ICMP fields

@jpinsonneau
Copy link
Contributor Author

/retest

@jpinsonneau jpinsonneau merged commit c0b9ab5 into netobserv:main Dec 10, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm no-qe This PR doesn't necessitate QE approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants