Skip to content

Conversation

jpinsonneau
Copy link
Contributor

Backport of #611

@jpinsonneau jpinsonneau requested a review from jotak October 7, 2024 12:11
@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.01%. Comparing base (0478ea6) to head (54453e4).
Report is 2 commits behind head on release-1.7.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.7     #612   +/-   ##
============================================
  Coverage        56.01%   56.01%           
============================================
  Files              193      193           
  Lines             9479     9479           
  Branches          1213     1213           
============================================
  Hits              5310     5310           
  Misses            3792     3792           
  Partials           377      377           
Flag Coverage Δ
uitests 57.72% <ø> (ø)
unittests 51.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
web/src/components/messages/status-texts.tsx 71.42% <ø> (ø)

Copy link

github-actions bot commented Oct 7, 2024

New image:
quay.io/netobserv/network-observability-console-plugin:4ac9d89

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=4ac9d89 make set-plugin-image

@openshift-ci openshift-ci bot added the lgtm label Oct 8, 2024
Copy link
Member

@memodi memodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Oct 9, 2024
Copy link

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit eaddfc2 into netobserv:release-1.7 Oct 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants