Skip to content

Conversation

jotak
Copy link
Member

@jotak jotak commented Oct 7, 2024

Also adds a tooltip with more info

Backport of #610

Also adds a tooltip with more info

apply left margin on tooltip

Increase slider min size
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Oct 7, 2024

@jotak: This pull request references NETOBSERV-1920 which is a valid jira issue.

In response to this:

Also adds a tooltip with more info

Backport of #610

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak requested a review from jpinsonneau October 7, 2024 15:18
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 56.00%. Comparing base (0478ea6) to head (d1b691d).
Report is 1 commits behind head on release-1.7.

Files with missing lines Patch % Lines
web/src/components/slider/scope-slider.tsx 12.50% 7 Missing ⚠️
web/src/components/slider/slider.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.7     #613      +/-   ##
===============================================
- Coverage        56.01%   56.00%   -0.02%     
===============================================
  Files              193      193              
  Lines             9479     9482       +3     
  Branches          1213     1214       +1     
===============================================
  Hits              5310     5310              
- Misses            3792     3795       +3     
  Partials           377      377              
Flag Coverage Δ
uitests 57.70% <10.00%> (-0.03%) ⬇️
unittests 51.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
web/src/components/slider/slider.tsx 5.26% <0.00%> (-0.08%) ⬇️
web/src/components/slider/scope-slider.tsx 33.33% <12.50%> (-2.39%) ⬇️

@jotak jotak merged commit d2a9636 into netobserv:release-1.7 Oct 8, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants