Skip to content

Conversation

jpinsonneau
Copy link
Contributor

Backport of #615

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.97%. Comparing base (d2a9636) to head (1bd5ba7).
Report is 2 commits behind head on release-1.7.

Files with missing lines Patch % Lines
web/src/components/netflow-traffic.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.7     #616      +/-   ##
===============================================
- Coverage        56.00%   55.97%   -0.03%     
===============================================
  Files              193      193              
  Lines             9482     9486       +4     
  Branches          1214     1215       +1     
===============================================
  Hits              5310     5310              
- Misses            3795     3799       +4     
  Partials           377      377              
Flag Coverage Δ
uitests 57.66% <0.00%> (-0.04%) ⬇️
unittests 51.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
web/src/components/netflow-traffic.tsx 68.06% <0.00%> (-0.78%) ⬇️

@Amoghrd
Copy link
Member

Amoghrd commented Oct 9, 2024

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

New image:
quay.io/netobserv/network-observability-console-plugin:8d554cc

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=8d554cc make set-plugin-image

@Amoghrd
Copy link
Member

Amoghrd commented Oct 9, 2024

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Oct 9, 2024
Copy link

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 809bd9f into netobserv:release-1.7 Oct 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants