Skip to content

Conversation

jotak
Copy link
Member

@jotak jotak commented Oct 10, 2024

Backport of #617

We're seeing a lot of errors with "no message found". This is because with Loki operator 6, the json of the error has changed. We need now to look at the "error" field.

Also add more debug logs

We're seeing a lot of errors with "no message found". This is because
with Loki operator 6, the json of the error has changed. We need now to
look at the "error" field.

Also add more debug logs
@jotak jotak requested a review from jpinsonneau October 10, 2024 11:34
Copy link

openshift-ci bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak changed the title Fix error logs/message for loki-op 6 Fix error logs/message for loki-op 6 [1.7 backport] Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 55.99%. Comparing base (eaddfc2) to head (6f80c0b).
Report is 2 commits behind head on release-1.7.

Files with missing lines Patch % Lines
pkg/handler/loki.go 28.57% 5 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.7     #618      +/-   ##
===============================================
- Coverage        56.00%   55.99%   -0.01%     
===============================================
  Files              193      193              
  Lines             9482     9487       +5     
  Branches          1214     1214              
===============================================
+ Hits              5310     5312       +2     
- Misses            3795     3798       +3     
  Partials           377      377              
Flag Coverage Δ
uitests 57.70% <ø> (ø)
unittests 51.30% <28.57%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/handler/loki.go 40.00% <28.57%> (ø)

@memodi
Copy link
Member

memodi commented Oct 10, 2024

/label no-qe

@openshift-ci openshift-ci bot added the no-qe This PR doesn't necessitate QE approval label Oct 10, 2024
@jotak jotak merged commit 44c2d0a into netobserv:release-1.7 Oct 11, 2024
5 of 6 checks passed
@jotak
Copy link
Member Author

jotak commented Oct 11, 2024

merging since the original PR was reviewed and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-qe This PR doesn't necessitate QE approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants