Skip to content

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Oct 17, 2024

Description

  • add missing update config target in MakeFile
  • update config from operator
  • manage drop columns to avoid duplicates in side panel

Dependencies

netobserv/network-observability-operator#819

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot removed the lgtm label Oct 18, 2024
@openshift-ci openshift-ci bot removed the lgtm label Nov 25, 2024
Copy link

openshift-ci bot commented Nov 25, 2024

New changes are detected. LGTM label has been removed.

@jpinsonneau
Copy link
Contributor Author

Resolved conflict without changes:
dc840d2

@jpinsonneau
Copy link
Contributor Author

Rebased without changes

@openshift-ci openshift-ci bot removed the lgtm label Dec 12, 2024
Copy link

openshift-ci bot commented Dec 12, 2024

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.83%. Comparing base (30fbfa6) to head (3378642).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
web/src/components/drawer/record/record-field.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #621   +/-   ##
=======================================
  Coverage   56.83%   56.83%           
=======================================
  Files         197      197           
  Lines       10146    10154    +8     
  Branches     1192     1192           
=======================================
+ Hits         5766     5771    +5     
- Misses       4012     4015    +3     
  Partials      368      368           
Flag Coverage Δ
uitests 59.22% <66.66%> (+<0.01%) ⬆️
unittests 51.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
web/src/components/drawer/record/record-panel.tsx 52.23% <100.00%> (ø)
web/src/utils/columns.ts 78.87% <100.00%> (+0.77%) ⬆️
web/src/components/drawer/record/record-field.tsx 51.14% <0.00%> (-0.90%) ⬇️

@jpinsonneau jpinsonneau merged commit 403e635 into netobserv:main Dec 13, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants