Skip to content

Conversation

OlivierCazade
Copy link
Collaborator

Description

  • pipeline refactoring to only have one pipeline definition
  • adding a dedicated downstream Dockerfile
  • adding multi arch build support

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.38%. Comparing base (b7fdf62) to head (b2698f1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
- Coverage   55.96%   55.38%   -0.59%     
==========================================
  Files         193      193              
  Lines        9491    10088     +597     
  Branches     1215     1215              
==========================================
+ Hits         5312     5587     +275     
- Misses       3802     4124     +322     
  Partials      377      377              
Flag Coverage Δ
uitests 57.66% <ø> (ø)
unittests 50.30% <ø> (-1.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 34 files with indirect coverage changes

@OlivierCazade
Copy link
Collaborator Author

/retest

@OlivierCazade OlivierCazade force-pushed the konflux-multiarch branch 14 times, most recently from d8d6806 to d5773b9 Compare October 28, 2024 16:47
@OlivierCazade
Copy link
Collaborator Author

/retest

3 similar comments
@OlivierCazade
Copy link
Collaborator Author

/retest

@OlivierCazade
Copy link
Collaborator Author

/retest

@OlivierCazade
Copy link
Collaborator Author

/retest

@OlivierCazade
Copy link
Collaborator Author

/retest

1 similar comment
@OlivierCazade
Copy link
Collaborator Author

/retest

@OlivierCazade
Copy link
Collaborator Author

/retest

@openshift-ci openshift-ci bot added the lgtm label Nov 5, 2024
@OlivierCazade
Copy link
Collaborator Author

/approve

Copy link

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: OlivierCazade

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 34ce8eb into netobserv:main Nov 5, 2024
12 checks passed
OlivierCazade added a commit to OlivierCazade/network-observability-console-plugin that referenced this pull request Nov 7, 2024
openshift-merge-bot bot pushed a commit that referenced this pull request Nov 7, 2024
…podman 5.2 … (#607)

* Addressing konflux error and fixing multi arch build with podman 5.2 (#595)

* Adding multiarch support in konflux build and some refactoring (#622)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants