NETOBSERV-1885: fix resources/names endpoint

[jpinsonneau]

Description

• Fix resources endpoint params not working. The routes:

"/resources/namespace/{namespace}/kind/{kind}/names"
"/resources/kind/{kind}/names"

are now moved to a single one:

"/resources/names"

The namespace and kind are now parameters instead of url parts.

• Improve filter toolbar to not crash when namespace filter is not available (mainly for dev purposes)

Dependencies

netobserv/network-observability-operator#820 for field descriptions update

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[codecov]

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 55.34%. Comparing base (b7fdf62) to head (bc0f58a).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
web/src/components/toolbar/filters-toolbar.tsx	30.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
- Coverage   55.96%   55.34%   -0.63%     
==========================================
  Files         193      193              
  Lines        9491    10096     +605     
  Branches     1215     1218       +3     
==========================================
+ Hits         5312     5588     +276     
- Misses       3802     4131     +329     
  Partials      377      377              

Flag	Coverage Δ
uitests	57.62% <30.00%> (-0.05%)	⬇️
unittests	50.28% <100.00%> (-1.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pkg/server/routes.go	70.00% <100.00%> (-0.74%)	⬇️
web/src/components/toolbar/filters-toolbar.tsx	63.15% <30.00%> (-5.50%)	⬇️

... and 33 files with indirect coverage changes

[openshift-ci-robot]

@jpinsonneau: This pull request references NETOBSERV-1885 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

Description

• Fix resources endpoint params not working. The routes:

"/resources/namespace/{namespace}/kind/{kind}/names"
"/resources/kind/{kind}/names"

are now moved to a single one:

"/resources/names"

The namespace and kind are now parameters instead of url parts.

• Improve filter toolbar to not crash when namespace filter is not available (mainly for dev purposes)

Dependencies

netobserv/network-observability-operator#820 for field descriptions update

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
• If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
• If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
• If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Amoghrd]

/ok-to-test

[github-actions]

New image:
quay.io/netobserv/network-observability-console-plugin:4f56035

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=4f56035 make set-plugin-image

[Amoghrd]

/label qe-approved

[openshift-ci-robot]

@jpinsonneau: This pull request references NETOBSERV-1885 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

Description

• Fix resources endpoint params not working. The routes:

"/resources/namespace/{namespace}/kind/{kind}/names"
"/resources/kind/{kind}/names"

are now moved to a single one:

"/resources/names"

The namespace and kind are now parameters instead of url parts.

• Improve filter toolbar to not crash when namespace filter is not available (mainly for dev purposes)

Dependencies

netobserv/network-observability-operator#820 for field descriptions update

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
• If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
• If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
• If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment