Skip to content

Conversation

msherif1234
Copy link
Contributor

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 28, 2024
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 28, 2024
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 28, 2024
Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:23d77e6

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=23d77e6 make set-plugin-image

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (01883f0) to head (c99c949).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
+ Coverage   56.70%   56.83%   +0.12%     
==========================================
  Files         197      197              
  Lines       10113    10148      +35     
  Branches     1192     1192              
==========================================
+ Hits         5735     5768      +33     
- Misses       4009     4012       +3     
+ Partials      369      368       -1     
Flag Coverage Δ
uitests 59.23% <100.00%> (+0.01%) ⬆️
unittests 51.71% <ø> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
web/src/api/ipfix.ts 100.00% <ø> (ø)
web/src/utils/columns.ts 78.41% <100.00%> (+0.31%) ⬆️

... and 8 files with indirect coverage changes

tcpflags = 'TCPFlags',
bytes = 'Bytes',
packets = 'Packets',
packets = 'Padstkubeobjectckets',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
packets = 'Padstkubeobjectckets',
packets = 'Packets',

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 28, 2024
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 28, 2024
Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:8093a9b

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=8093a9b make set-plugin-image

@msherif1234
Copy link
Contributor Author

/ok-to-test

@msherif1234 msherif1234 removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 22, 2024
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Nov 22, 2024
Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:4ab9c86

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=4ab9c86 make set-plugin-image

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 3, 2024
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

New image:
quay.io/netobserv/network-observability-console-plugin:32aa477

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=32aa477 make set-plugin-image

@msherif1234 msherif1234 marked this pull request as ready for review December 9, 2024 13:32
@msherif1234 msherif1234 changed the title WIP: pkt translation enrichment NETOBSERV-1965: pkt translation enrichment Dec 9, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 9, 2024

@msherif1234: This pull request references NETOBSERV-1965 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Signed-off-by: Mohamed Mahmoud <[email protected]>
Copy link

openshift-ci bot commented Dec 11, 2024

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from oliviercazade. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 11, 2024
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 12, 2024
Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:43d0aa4

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=43d0aa4 make set-plugin-image

Comment on lines +182 to +189
/** Xlat Source IP address (ipv4 or ipv6) */
XlatSrcAddr?: string;
/** Xlat Destination IP address (ipv4 or ipv6) */
XlatDstAddr?: string;
/** Xlat Source port */
XlatSrcPort?: number;
/** Xlat Destination port */
XlatDstPort?: number;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can do that but it's not required anymore since it's defined from config

srckubeobject = 'SrcK8S_Object',
dstkubeobject = 'DstK8S_Object',
xlatsrckubeobject = 'XlatSrcK8S_Object',
xlatdstkubeobject = 'XlatDstK8S_Object',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here I think it's not needed, so I'd say the whole PR is not needed

@msherif1234
Copy link
Contributor Author

not needed anymore will close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants