-
Notifications
You must be signed in to change notification settings - Fork 22
NETOBSERV-1965: pkt translation enrichment #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/ok-to-test |
0927273
to
9078c45
Compare
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=23d77e6 make set-plugin-image |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #626 +/- ##
==========================================
+ Coverage 56.70% 56.83% +0.12%
==========================================
Files 197 197
Lines 10113 10148 +35
Branches 1192 1192
==========================================
+ Hits 5735 5768 +33
- Misses 4009 4012 +3
+ Partials 369 368 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
web/src/utils/columns.ts
Outdated
tcpflags = 'TCPFlags', | ||
bytes = 'Bytes', | ||
packets = 'Packets', | ||
packets = 'Padstkubeobjectckets', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packets = 'Padstkubeobjectckets', | |
packets = 'Packets', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops
9078c45
to
2ff2ab5
Compare
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=8093a9b make set-plugin-image |
/ok-to-test |
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=4ab9c86 make set-plugin-image |
2ff2ab5
to
78caaf2
Compare
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=32aa477 make set-plugin-image |
@msherif1234: This pull request references NETOBSERV-1965 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Signed-off-by: Mohamed Mahmoud <[email protected]>
78caaf2
to
c99c949
Compare
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=43d0aa4 make set-plugin-image |
/** Xlat Source IP address (ipv4 or ipv6) */ | ||
XlatSrcAddr?: string; | ||
/** Xlat Destination IP address (ipv4 or ipv6) */ | ||
XlatDstAddr?: string; | ||
/** Xlat Source port */ | ||
XlatSrcPort?: number; | ||
/** Xlat Destination port */ | ||
XlatDstPort?: number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can do that but it's not required anymore since it's defined from config
srckubeobject = 'SrcK8S_Object', | ||
dstkubeobject = 'DstK8S_Object', | ||
xlatsrckubeobject = 'XlatSrcK8S_Object', | ||
xlatdstkubeobject = 'XlatDstK8S_Object', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here I think it's not needed, so I'd say the whole PR is not needed
not needed anymore will close it |
Description
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.