Skip to content

Conversation

OlivierCazade
Copy link
Collaborator

Description

Fixing build version during image build

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.66%. Comparing base (900f210) to head (7cf8e4f).
Report is 1 commits behind head on release-1.7.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.7     #652      +/-   ##
===============================================
+ Coverage        55.38%   57.66%   +2.28%     
===============================================
  Files              193      156      -37     
  Lines            10088     6957    -3131     
  Branches          1215     1215              
===============================================
- Hits              5587     4012    -1575     
+ Misses            4124     2732    -1392     
+ Partials           377      213     -164     
Flag Coverage Δ
uitests 57.66% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 37 files with indirect coverage changes

@OlivierCazade
Copy link
Collaborator Author

/retest

2 similar comments
@OlivierCazade
Copy link
Collaborator Author

/retest

@OlivierCazade
Copy link
Collaborator Author

/retest

@OlivierCazade OlivierCazade force-pushed the konflux-version-fix branch 2 times, most recently from 74fb97b to fc15d84 Compare November 25, 2024 21:00
Copy link

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 32c6639 into netobserv:release-1.7 Nov 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant