Skip to content

Conversation

jotak
Copy link
Member

@jotak jotak commented Jan 21, 2025

Related to netobserv/netobserv-ebpf-agent#509

It's only for a rare corner case, I don't expect to see it much. In the eBPF agent, in case where an interface is traversed both as ingress and egress for the same flow, it would store a special value as a direction.

image
(I used fake data for this screenshot)

Copy link

openshift-ci bot commented Jan 21, 2025

@jotak: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/plugin-cypress 40dc477 link true /test plugin-cypress
ci/prow/qe-e2e-console-tests 40dc477 link false /test qe-e2e-console-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jpinsonneau
Copy link
Contributor

What do we do with the metrics here ? 🤔

@jotak
Copy link
Member Author

jotak commented Jan 23, 2025

What do we do with the metrics here ? 🤔

If you mean this sort of things, it should not be impacted, because here it's about IfDirections and not FlowDirection

Copy link

openshift-ci bot commented Jan 27, 2025

New changes are detected. LGTM label has been removed.

@jotak
Copy link
Member Author

jotak commented Jan 27, 2025

/approve

Copy link

openshift-ci bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak merged commit 39d2fb0 into netobserv:main Jan 27, 2025
4 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants