Skip to content

Conversation

jpinsonneau
Copy link
Contributor

Description

Remove 3D topology as it never been supported and it's creating a blob at startup which makes Console complains because of Content Security Policy.

This is a workaround since CSP are buggy in OCP4.18

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@jpinsonneau jpinsonneau requested a review from jotak January 22, 2025 09:47
@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 22, 2025
Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:594b48d

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=594b48d make set-plugin-image

@jotak
Copy link
Member

jotak commented Jan 22, 2025

/lgtm
btw I'm not sure why this blob was loaded in the first place, even though the 3d topology isn't invoked. Looks like some static resource loaded via one of the included dependency? I wonder if there would be a way to get rid of that (which would allow to reintroduce the 3d topo)

@jpinsonneau
Copy link
Contributor Author

/lgtm btw I'm not sure why this blob was loaded in the first place, even though the 3d topology isn't invoked. Looks like some static resource loaded via one of the included dependency? I wonder if there would be a way to get rid of that (which would allow to reintroduce the 3d topo)

It's related to threejs which is quite huge and complex. I don't think 3D topology will come back in the future from what I heard.

@Amoghrd
Copy link
Member

Amoghrd commented Jan 22, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Jan 22, 2025
Copy link

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Jan 23, 2025

@jpinsonneau: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/qe-e2e-console-tests c7103de link false /test qe-e2e-console-tests
ci/prow/plugin-cypress c7103de link true /test plugin-cypress

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jpinsonneau
Copy link
Contributor Author

Cypress error is not related to this PR. It seems we have an issue with the expected count of columns.
Will check in a followup:

  1) netflow-table
       manage columns:
      AssertionError: Timed out retrying after 10000ms: Too many elements found. Found '57', expected '56'.
      + expected - actual
      -57
      +56
      
      at Context.eval (webpack://netobserv-plugin/./cypress/support/commands.ts:107:65)

@jpinsonneau jpinsonneau merged commit e4fe8e5 into netobserv:main Jan 23, 2025
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants