Skip to content

Conversation

jpinsonneau
Copy link
Contributor

Description

Improve table display to avoid inconsistent row heights.

  • remove on mouse hover
  • improve truncate for multi rows

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Amoghrd
Copy link
Member

Amoghrd commented Jan 28, 2025

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 28, 2025
Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:ce302da

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=ce302da make set-plugin-image

Copy link

openshift-ci bot commented Jan 28, 2025

@jpinsonneau: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/plugin-cypress 958ee46 link true /test plugin-cypress
ci/prow/qe-e2e-console-tests 958ee46 link false /test qe-e2e-console-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Amoghrd
Copy link
Member

Amoghrd commented Jan 28, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Jan 28, 2025
Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maybe to be backported?

@openshift-ci openshift-ci bot added the lgtm label Jan 30, 2025
@jotak jotak changed the title NETOBSERV-2049 Console table rows height are inconsistent NETOBSERV-2049: Console table rows height are inconsistent Jan 30, 2025
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jan 30, 2025

@jpinsonneau: This pull request references NETOBSERV-2049 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Description

Improve table display to avoid inconsistent row heights.

  • remove on mouse hover
  • improve truncate for multi rows

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jotak
Copy link
Member

jotak commented Jan 30, 2025

hey, just in case you wonder: if I'm often changing the title like that:
image
it's not because of an obsessive–compulsive disorder ... just because it makes JIRA link to the PR :-)

@jpinsonneau
Copy link
Contributor Author

hey, just in case you wonder: if I'm often changing the title like that: image it's not because of an obsessive–compulsive disorder ... just because it makes JIRA link to the PR :-)

oh wow. It's not working anymore without adding the : ?

@jpinsonneau jpinsonneau merged commit 0350685 into netobserv:main Jan 30, 2025
7 of 12 checks passed
@jotak
Copy link
Member

jotak commented Jan 30, 2025

hey, just in case you wonder: if I'm often changing the title like that: image it's not because of an obsessive–compulsive disorder ... just because it makes JIRA link to the PR :-)

oh wow. It's not working anymore without adding the : ?

I think it works in one way but not the other, if you don't set it. Like, you get the link from jira to github, but not from github to jira

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants