Skip to content

NETOBSERV-1992: explain partial flows [backport 1.8] #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2025
Merged

NETOBSERV-1992: explain partial flows [backport 1.8] #704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
160bd8c
NETOBSERV-1992: explain partial flows
jotak Jan 16, 2025
2752c7d
format
jotak Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions web/locales/en/plugin__netobserv-plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
"Switch {{name}} option": "Switch {{name}} option",
"Conversation event information": "Conversation event information",
"Flow information": "Flow information",
"This is a partial flow: it contains only enrichment data and is missing some basic information such as byte and packet counters, TCP flags or MAC addresses. This information can likely be found in adjacent flows.": "This is a partial flow: it contains only enrichment data and is missing some basic information such as byte and packet counters, TCP flags or MAC addresses. This information can likely be found in adjacent flows.",
"More info": "More info",
"Raw": "Raw",
"JSON": "JSON",
Expand Down
11 changes: 10 additions & 1 deletion web/src/components/drawer/record/record-panel.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,13 @@ div.record-field-popover-body,
div.record-field-popover-footer {
white-space: pre-line;
word-break: break-word;
}
}

.record-panel-warning {
color: #2B9AF3;
margin-right: 5px;
}

#partial-flow-text {
margin-bottom: 10px;
}
11 changes: 11 additions & 0 deletions web/src/components/drawer/record/record-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
TextContent,
TextVariants
} from '@patternfly/react-core';
import { InfoCircleIcon } from '@patternfly/react-icons';
import _ from 'lodash';
import * as React from 'react';
import { useTranslation } from 'react-i18next';
Expand Down Expand Up @@ -342,6 +343,8 @@
)
);

const isPartialFlow = !record.fields.Bytes && !record.fields.Packets;

return (
<DrawerPanelContent
data-test-id={id}
Expand Down Expand Up @@ -370,6 +373,14 @@
role="region"
>
<Tab className="drawer-tab" eventKey={'details'} title={<TabTitleText>{t('Details')}</TabTitleText>}>
{isPartialFlow && (
<Text id="partial-flow-text" component={TextVariants.p}>
<InfoCircleIcon className="record-panel-warning" />
{t(
'This is a partial flow: it contains only enrichment data and is missing some basic information such as byte and packet counters, TCP flags or MAC addresses. This information can likely be found in adjacent flows.'

Check warning on line 380 in web/src/components/drawer/record/record-panel.tsx

View workflow job for this annotation

GitHub Actions / Build, lint, test frontend 

This line has a length of 232. Maximum allowed is 170

Check warning on line 380 in web/src/components/drawer/record/record-panel.tsx

View workflow job for this annotation

GitHub Actions / Build, lint, test frontend 

This line has a length of 232. Maximum allowed is 170
)}
</Text>
)}
<Accordion asDefinitionList={false}>
{groups.map((g, i) =>
getGroup(
Expand Down