-
Notifications
You must be signed in to change notification settings - Fork 22
NETOBSERV-2104 Filters in UI are visible despite features are disabled #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/ok-to-test |
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=cedf9e3 make set-plugin-image |
|
@jpinsonneau This PR seems to have broken all filters. Now I see only Xlat related filters(even though it is not enabled) And none of the other filters are seen |
Co-authored-by: Amogh Rameshappa Devapura <[email protected]>
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=642afef make set-plugin-image |
|
/label qe-approved |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@jpinsonneau: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
f66864c
into
netobserv:main
#755) * manage missing features on filters * Update web/src/components/netflow-traffic.tsx Co-authored-by: Amogh Rameshappa Devapura <[email protected]> --------- Co-authored-by: Amogh Rameshappa Devapura <[email protected]>

Description
Some of the features filtering is still hardcoded such as for filters.
I would suggest to merge this for now as a quick win and investigate about a more generic solution in parallel.
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.