Skip to content

Conversation

@jpinsonneau
Copy link
Contributor

Description

Some of the features filtering is still hardcoded such as for filters.
I would suggest to merge this for now as a quick win and investigate about a more generic solution in parallel.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@Amoghrd
Copy link
Member

Amoghrd commented Feb 26, 2025

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 26, 2025
@github-actions
Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:cedf9e3

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=cedf9e3 make set-plugin-image

@Amoghrd
Copy link
Member

Amoghrd commented Feb 26, 2025

@jpinsonneau This PR seems to have broken all filters. Now I see only Xlat related filters(even though it is not enabled) And none of the other filters are seen
Screenshot 2025-02-26 at 3 42 37 PM

Co-authored-by: Amogh Rameshappa Devapura <[email protected]>
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 27, 2025
@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Feb 27, 2025
@github-actions
Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:642afef

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=642afef make set-plugin-image

@openshift-ci openshift-ci bot added the lgtm label Mar 3, 2025
@Amoghrd
Copy link
Member

Amoghrd commented Mar 6, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Mar 6, 2025
@openshift-ci
Copy link

openshift-ci bot commented Mar 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Mar 10, 2025

@jpinsonneau: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/qe-e2e-console-tests ce6c08c link false /test qe-e2e-console-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f66864c into netobserv:main Mar 10, 2025
12 of 13 checks passed
jotak pushed a commit that referenced this pull request May 15, 2025
#755)

* manage missing features on filters

* Update web/src/components/netflow-traffic.tsx

Co-authored-by: Amogh Rameshappa Devapura <[email protected]>

---------

Co-authored-by: Amogh Rameshappa Devapura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants