Skip to content

(Trivial) Rename role netobserv-reader => netobserv-loki-reader #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

(Trivial) Rename role netobserv-reader => netobserv-loki-reader #802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/locales/en/plugin__netobserv-plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@
"Check current user permissions": "Check current user permissions",
"This deployment mode does not support non-admin users. Check FlowCollector spec.loki.manual.authToken": "This deployment mode does not support non-admin users. Check FlowCollector spec.loki.manual.authToken",
"For LokiStack, your user must either:": "For LokiStack, your user must either:",
"have the 'netobserv-reader' cluster role, which allows multi-tenancy": "have the 'netobserv-reader' cluster role, which allows multi-tenancy",
"have the 'netobserv-loki-reader' cluster role, which allows multi-tenancy": "have the 'netobserv-loki-reader' cluster role, which allows multi-tenancy",
"or be in the 'cluster-admin' group (not the same as the 'cluster-admin' role)": "or be in the 'cluster-admin' group (not the same as the 'cluster-admin' role)",
"or LokiStack spec.tenants.openshift.adminGroups must be configured with a group this user belongs to": "or LokiStack spec.tenants.openshift.adminGroups must be configured with a group this user belongs to",
"For other configurations, refer to FlowCollector spec.loki.manual.authToken": "For other configurations, refer to FlowCollector spec.loki.manual.authToken",
Expand Down
2 changes: 1 addition & 1 deletion web/src/components/messages/error.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ export const Error: React.FC<ErrorProps> = ({ title, error, isLokiRelated }) =>
{t(`For LokiStack, your user must either:`)}
<TextList>
<TextListItem>
{t(`have the 'netobserv-reader' cluster role, which allows multi-tenancy`)}
{t(`have the 'netobserv-loki-reader' cluster role, which allows multi-tenancy`)}
</TextListItem>
<TextListItem>
{t(`or be in the 'cluster-admin' group (not the same as the 'cluster-admin' role)`)}
Expand Down