Skip to content

Conversation

@memodi
Copy link
Member

@memodi memodi commented Apr 30, 2025

Description

NETOBSERV-2233 Make IPSec filters visible if feature is enabled

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@memodi memodi requested a review from jpinsonneau April 30, 2025 20:27
@memodi
Copy link
Member Author

memodi commented Apr 30, 2025

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Apr 30, 2025
@github-actions
Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:415ee6b

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=415ee6b make set-plugin-image

@Amoghrd
Copy link
Member

Amoghrd commented May 2, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label May 2, 2025
@memodi
Copy link
Member Author

memodi commented May 6, 2025

/test plugin-cypress

@openshift-ci openshift-ci bot removed the lgtm label May 7, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 7, 2025

New changes are detected. LGTM label has been removed.

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 7, 2025
@memodi
Copy link
Member Author

memodi commented May 7, 2025

@Amoghrd @jpinsonneau In 2eb5a4b I updated table.spec.ts to remove "Show Duplicates" check, I think it's outdated and that option no longer exists in UI:

Screenshot 2025-05-07 at 3 41 32 PM

@memodi
Copy link
Member Author

memodi commented May 8, 2025

/test plugin-cypress

@jpinsonneau
Copy link
Contributor

@Amoghrd @jpinsonneau In 2eb5a4b I updated table.spec.ts to remove "Show Duplicates" check, I think it's outdated and that option no longer exists in UI:

Screenshot 2025-05-07 at 3 41 32 PM

This been moved in table display options:
#775

@memodi
Copy link
Member Author

memodi commented May 12, 2025

@jpinsonneau thanks, since these are unrelated to changes in PR, we should address them in different PR and have this PR merged. I created this task to make changes to UI tests https://issues.redhat.com/browse/NETOBSERV-2252 and reverted my last change to table.spec.ts what do you think?

@memodi
Copy link
Member Author

memodi commented May 12, 2025

/label needs-review

@openshift-ci
Copy link

openshift-ci bot commented May 12, 2025

@memodi: The label(s) /label needs-review cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label needs-review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@memodi memodi added the needs-review Tells that the PR needs a review label May 12, 2025
@memodi memodi requested a review from jpinsonneau May 12, 2025 20:18
@openshift-ci
Copy link

openshift-ci bot commented May 12, 2025

@memodi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/plugin-cypress fe9d916 link true /test plugin-cypress
ci/prow/qe-e2e-console-tests fe9d916 link false /test qe-e2e-console-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jpinsonneau
Copy link
Contributor

@jpinsonneau thanks, since these are unrelated to changes in PR, we should address them in different PR and have this PR merged. I created this task to make changes to UI tests https://issues.redhat.com/browse/NETOBSERV-2252 and reverted my last change to table.spec.ts what do you think?

sure !

@openshift-ci
Copy link

openshift-ci bot commented May 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau jpinsonneau merged commit 489bd5d into netobserv:main May 13, 2025
6 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved needs-review Tells that the PR needs a review qe-approved QE has approved this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants