NETOBSERV-2227: UDN adjustments, and auto-detect filters #846

jotak · 2025-05-13T13:34:05Z

Description

Auto-detect available filters per feature (so we don't need to implement specific code to detect when NetworkName filters (for instance) are available)
Add tests for auto-detection
Do not display "None" as a UDN label

Dependencies

Operator: NETOBSERV-2227: plugin feature "multiNetworks", and promote NetworkName columns network-observability-operator#1508

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

openshift-ci-robot · 2025-05-13T13:34:10Z

openshift-ci · 2025-05-13T13:34:15Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jotak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-05-13T15:47:51Z

github-actions · 2025-05-14T05:14:56Z

New image:
quay.io/netobserv/network-observability-console-plugin:3dddc24

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=3dddc24 make set-plugin-image

github-actions · 2025-05-14T08:09:45Z

New image:
quay.io/netobserv/network-observability-console-plugin:309506a

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=309506a make set-plugin-image

jpinsonneau · 2025-05-14T09:48:11Z

web/src/components/drawer/record/record-field.tsx

+            value
+              .map(iName => String(iName))
+              .filter(iName => iName !== '')
+              .map(iName => simpleTextWithTooltip(iName)),


Why not showing n/a greyed out for empty ones ?

Currently it's empty. That feels strange compared to other fields:

done in 6d8cec6

jpinsonneau · 2025-05-14T09:58:59Z

web/src/components/netflow-traffic.tsx

+    return getFilterDefinitions(model.config.filters, model.config.columns, t).filter(fd => {
+      if (fd.id === 'id') {
+        return isConnectionTracking();
+      }
+      return checkFilterAvailable(fd, model.config, model.dataSource);
+    });
    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [model.config.columns, model.config.filters, model.config.promLabels, isPromOnly]);
+  }, [model.config, model.dataSource]);


I think there was some exceptions here:

You already managed the UDN one

I see drop state and cause filters when packet drop feature is not enabled

Others filters seems to work properly 👌

did you take the operator PR too? The issue with drops is supposed to be fixed from the operator config

I was using it yes

weird, I don't have them

the operator generated image was prior to this commit, I guess you used that old one; just triggered a new one

Amoghrd · 2025-05-14T13:18:26Z

/ok-to-test

github-actions · 2025-05-14T13:22:00Z

New image:
quay.io/netobserv/network-observability-console-plugin:392537c

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=392537c make set-plugin-image

Amoghrd · 2025-05-14T14:17:04Z

/ok-to-test

github-actions · 2025-05-14T14:20:53Z

New image:
quay.io/netobserv/network-observability-console-plugin:cada95b

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=cada95b make set-plugin-image

- Auto-detect available filters per feature (so we don't need to implement specific code to detect when NetworkName filters (for instance) are available) - Add tests for auto-detection - Do not display "None" as a UDN label

github-actions · 2025-05-16T08:31:51Z

New image:
quay.io/netobserv/network-observability-console-plugin:1032074

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=1032074 make set-plugin-image

github-actions · 2025-05-16T11:52:09Z

New image:
quay.io/netobserv/network-observability-console-plugin:f3d666b

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=f3d666b make set-plugin-image

openshift-ci · 2025-05-16T13:12:42Z

@jotak: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/plugin-cypress	`00c0312`	link	true	`/test plugin-cypress`
ci/prow/qe-e2e-console-tests	`00c0312`	link	false	`/test qe-e2e-console-tests`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Amoghrd · 2025-05-16T17:23:19Z

/label qe-approved

openshift-ci-robot · 2025-05-16T17:23:26Z

* NETOBSERV-2227: UDN adjustments, and auto-detect filters - Auto-detect available filters per feature (so we don't need to implement specific code to detect when NetworkName filters (for instance) are available) - Add tests for auto-detection - Do not display "None" as a UDN label * Remove unnecessary Filter on Field * write n/a for no udn * Fix css alignment for n/a text * Fix empty udn name

jotak requested review from OlivierCazade and jpinsonneau May 13, 2025 13:34

openshift-ci-robot added the jira/valid-reference label May 13, 2025

openshift-merge-robot added the needs-rebase label May 13, 2025

jotak force-pushed the udn branch from 175e0a5 to 0d3b7ea Compare May 13, 2025 13:35

openshift-merge-robot removed the needs-rebase label May 13, 2025

jotak force-pushed the udn branch from 0d3b7ea to ee550ae Compare May 13, 2025 13:45

jotak mentioned this pull request May 13, 2025

NETOBSERV-2227: plugin feature "multiNetworks", and promote NetworkName columns netobserv/network-observability-operator#1508

Merged

10 tasks

jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 14, 2025

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 14, 2025

jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 14, 2025

jpinsonneau reviewed May 14, 2025

View reviewed changes

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 14, 2025

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 14, 2025

jotak force-pushed the udn branch from 6d8cec6 to a6765f1 Compare May 14, 2025 13:25

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 14, 2025

jotak added the needs-review Tells that the PR needs a review label May 14, 2025

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 14, 2025

jotak added 2 commits May 16, 2025 10:27

NETOBSERV-2227: UDN adjustments, and auto-detect filters

9bf06a6

- Auto-detect available filters per feature (so we don't need to implement specific code to detect when NetworkName filters (for instance) are available) - Add tests for auto-detection - Do not display "None" as a UDN label

Remove unnecessary Filter on Field

f72d9a3

write n/a for no udn

f346474

jotak force-pushed the udn branch from a6765f1 to f346474 Compare May 16, 2025 08:27

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 16, 2025

jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 16, 2025

Fix css alignment for n/a text

78adca2

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 16, 2025

jotak requested a review from jpinsonneau May 16, 2025 09:07

Fix empty udn name

00c0312

jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 16, 2025

openshift-ci bot added the qe-approved QE has approved this pull request label May 16, 2025

jpinsonneau approved these changes May 20, 2025

View reviewed changes

openshift-ci bot assigned jpinsonneau May 20, 2025

openshift-ci bot added the lgtm label May 20, 2025

jotak merged commit ca69ede into netobserv:main May 20, 2025
10 of 13 checks passed

NETOBSERV-2227: UDN adjustments, and auto-detect filters #846

NETOBSERV-2227: UDN adjustments, and auto-detect filters #846

Uh oh!

Conversation

jotak commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies

Checklist

Uh oh!

openshift-ci-robot commented May 13, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies

Checklist

Uh oh!

openshift-ci bot commented May 13, 2025

Uh oh!

openshift-ci-robot commented May 13, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies

Checklist

Uh oh!

github-actions bot commented May 14, 2025

Uh oh!

github-actions bot commented May 14, 2025

Uh oh!

jpinsonneau May 14, 2025

Choose a reason for hiding this comment

Uh oh!

jotak May 14, 2025

Choose a reason for hiding this comment

Uh oh!

jpinsonneau May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jpinsonneau May 14, 2025

Choose a reason for hiding this comment

Uh oh!

jotak May 14, 2025

Choose a reason for hiding this comment

Uh oh!

jpinsonneau May 14, 2025

Choose a reason for hiding this comment

Uh oh!

jotak May 14, 2025

Choose a reason for hiding this comment

Uh oh!

jotak May 14, 2025

Choose a reason for hiding this comment

Uh oh!

Amoghrd commented May 14, 2025

Uh oh!

github-actions bot commented May 14, 2025

Uh oh!

Amoghrd commented May 14, 2025

Uh oh!

github-actions bot commented May 14, 2025

Uh oh!

github-actions bot commented May 16, 2025

Uh oh!

github-actions bot commented May 16, 2025

Uh oh!

openshift-ci bot commented May 16, 2025

Uh oh!

Amoghrd commented May 16, 2025

Uh oh!

openshift-ci-robot commented May 16, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies

Checklist

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

jotak commented May 13, 2025 •

edited

Loading

openshift-ci-robot commented May 13, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented May 13, 2025 •

edited by openshift-ci bot

Loading

jpinsonneau May 14, 2025 •

edited

Loading

openshift-ci-robot commented May 16, 2025 •

edited by openshift-ci bot

Loading