Skip to content

Conversation

@jpinsonneau
Copy link
Contributor

Description

Fix expand / collapse for PF6 clusters

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@openshift-ci
Copy link

openshift-ci bot commented Jul 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jpinsonneau for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Jul 7, 2025
@Amoghrd
Copy link
Member

Amoghrd commented Jul 15, 2025

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 15, 2025
@github-actions
Copy link

New image:
quay.io/netobserv/network-observability-console-plugin:6690c0f

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=6690c0f make set-plugin-image

@Amoghrd
Copy link
Member

Amoghrd commented Jul 15, 2025

@jpinsonneau The PR works as expected when expanding but I see an issue when collapsing wherein the side menu does not come back. PFA the screenrecording

Screen.Recording.2025-07-15.at.11.18.07.AM.mov

@openshift-ci
Copy link

openshift-ci bot commented Jul 15, 2025

@jpinsonneau: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/plugin-cypress a0a170d link true /test plugin-cypress
ci/prow/qe-e2e-console-tests a0a170d link false /test qe-e2e-console-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jpinsonneau
Copy link
Contributor Author

@jpinsonneau The PR works as expected when expanding but I see an issue when collapsing wherein the side menu does not come back. PFA the screenrecording

Screen.Recording.2025-07-15.at.11.18.07.AM.mov

Yes that's the way I implemented it for now. If you want I can keep the previous state of the left menu in cache and restore it after but I felt it was not really needed there.
What do you think ?

@Amoghrd
Copy link
Member

Amoghrd commented Jul 15, 2025

Yeah I dont mind this approach either. It was different from before so wanted to flag it. But yeah sounds good!
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved QE has approved this pull request label Jul 15, 2025
@jpinsonneau jpinsonneau merged commit 9d44efd into netobserv:main Jul 16, 2025
8 of 11 checks passed
@jotak
Copy link
Member

jotak commented Jul 17, 2025

/cherry-pick release-1.9

@openshift-cherrypick-robot

@jotak: new pull request created: #938

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. qe-approved QE has approved this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants