-
Notifications
You must be signed in to change notification settings - Fork 22
NETOBSERV-2304 Expand window does not take up menu space #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/ok-to-test |
|
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=6690c0f make set-plugin-image |
|
@jpinsonneau The PR works as expected when expanding but I see an issue when collapsing wherein the side menu does not come back. PFA the screenrecording Screen.Recording.2025-07-15.at.11.18.07.AM.mov |
|
@jpinsonneau: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Yes that's the way I implemented it for now. If you want I can keep the previous state of the left menu in cache and restore it after but I felt it was not really needed there. |
|
Yeah I dont mind this approach either. It was different from before so wanted to flag it. But yeah sounds good! |
|
/cherry-pick release-1.9 |
|
@jotak: new pull request created: #938 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Fix expand / collapse for PF6 clusters
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.