Skip to content

RELEASE BLOCKER(March 17, 2025): Add fbc-target-index-pruning-check to FBC pipelines#1208

Merged
jotak merged 1 commit intonetobserv:release-1.8from
nmars:add-fbc-pruning-check-release-1.8
Mar 11, 2025
Merged

RELEASE BLOCKER(March 17, 2025): Add fbc-target-index-pruning-check to FBC pipelines#1208
jotak merged 1 commit intonetobserv:release-1.8from
nmars:add-fbc-pruning-check-release-1.8

Conversation

@nmars
Copy link
Contributor

@nmars nmars commented Mar 3, 2025

A new task in the FBC builder pipeline will soon become required by Konflux's Conforma policies.

The task definition can be found here:

Ref:

Add fbc-target-index-pruning-check to FBC pipelines

Signed-off-by: nmars <nmarsell@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Mar 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oliviercazade for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Mar 3, 2025

Hi @nmars. Thanks for your PR.

I'm waiting for a netobserv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jotak
Copy link
Member

jotak commented Mar 6, 2025

thanks @nmars !
/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. and removed needs-ok-to-test labels Mar 6, 2025
@github-actions
Copy link

github-actions bot commented Mar 6, 2025

New images:

  • quay.io/netobserv/network-observability-operator:d030c5d
  • quay.io/netobserv/network-observability-operator-bundle:v0.0.0-d030c5d
  • quay.io/netobserv/network-observability-operator-catalog:v0.0.0-d030c5d

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:d030c5d make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-d030c5d

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-d030c5d
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.46%. Comparing base (f2ffbee) to head (6d2e2f5).
Report is 6 commits behind head on release-1.8.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.8    #1208      +/-   ##
===============================================
+ Coverage        62.42%   62.46%   +0.04%     
===============================================
  Files               77       77              
  Lines            11581    11581              
===============================================
+ Hits              7229     7234       +5     
+ Misses            3893     3889       -4     
+ Partials           459      458       -1     
Flag Coverage Δ
unittests 62.46% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jotak jotak merged commit c5348ab into netobserv:release-1.8 Mar 11, 2025
13 of 14 checks passed
jotak pushed a commit that referenced this pull request Mar 11, 2025
…1208)

Add fbc-target-index-pruning-check to FBC pipelines

Signed-off-by: nmars <nmarsell@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants