Skip to content

Conversation

@jotak
Copy link
Member

@jotak jotak commented Mar 11, 2025

No description provided.

@jotak jotak requested a review from msherif1234 March 11, 2025 07:57
@openshift-ci
Copy link

openshift-ci bot commented Mar 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.42%. Comparing base (34092ad) to head (b1acb76).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
controllers/ebpf/agent_controller.go 0.00% 0 Missing and 1 partial ⚠️
controllers/ebpf/bpfmanager-controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1221      +/-   ##
==========================================
+ Coverage   62.38%   62.42%   +0.03%     
==========================================
  Files          77       77              
  Lines       11581    11581              
==========================================
+ Hits         7225     7229       +4     
+ Misses       3898     3893       -5     
- Partials      458      459       +1     
Flag Coverage Δ
unittests 62.42% <33.33%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/helper/flowcollector.go 82.37% <100.00%> (ø)
controllers/ebpf/agent_controller.go 45.96% <0.00%> (ø)
controllers/ebpf/bpfmanager-controller.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jotak
Copy link
Member Author

jotak commented Mar 19, 2025

Self-merging / trivial change

@jotak jotak merged commit 8bd0032 into netobserv:main Mar 19, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant