NETOBSERV-1418: make namespace immutable

[jotak]

Description

It's now impossible to change the namespace where netobserv components are deployed (driven by spec.namespace); if users want to do so, they need to delete then recreate the FlowCollector.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[openshift-ci-robot]

@jotak: This pull request references NETOBSERV-1418 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Description

It's now impossible to change the namespace where netobserv components are deployed (driven by spec.namespace); if users want to do so, they need to delete then recreate the FlowCollector.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
• If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
• If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
• If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jotak]

@memodi @Amoghrd : if you had tests covering the namespace change, they are now obsolete

[codecov]

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.61%. Comparing base (a064cfe) to head (2ba2ab1).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
controllers/ebpf/agent_controller.go	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1229      +/-   ##
==========================================
- Coverage   62.61%   62.61%   -0.01%     
==========================================
  Files          76       76              
  Lines       11613    11500     -113     
==========================================
- Hits         7272     7201      -71     
+ Misses       3875     3839      -36     
+ Partials      466      460       -6     

Flag	Coverage Δ
unittests	62.61% <95.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
apis/flowcollector/v1beta1/flowcollector_types.go	100.00% <ø> (ø)
apis/flowcollector/v1beta2/flowcollector_types.go	100.00% <ø> (ø)
...trollers/consoleplugin/consoleplugin_reconciler.go	68.78% <ø> (-0.36%)	⬇️
controllers/ebpf/bpfmanager-controller.go	0.00% <ø> (ø)
...ntrollers/ebpf/internal/permissions/permissions.go	78.83% <ø> (+8.71%)	⬆️
controllers/flowcollector_controller.go	71.81% <100.00%> (-1.46%)	⬇️
controllers/flp/flp_controller.go	63.63% <100.00%> (-0.78%)	⬇️
controllers/flp/flp_monolith_reconciler.go	56.37% <ø> (-0.58%)	⬇️
controllers/flp/flp_transfo_reconciler.go	58.38% <ø> (-0.52%)	⬇️
controllers/reconcilers/common.go	88.88% <ø> (-1.12%)	⬇️
... and 2 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[memodi]

/ok-to-test

[memodi]

@jotak looks like operator-sdk is not like leading 0's in short sha that generated:

Error: invalid command options: 0.0.0-0010551 is not a valid semantic version: Numeric PreRelease version must not contain leading zeroes "0010551"
Usage:

could you rebase? probably that will generated new sha hopefully without leading 0s?

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jotak]

@jotak looks like operator-sdk is not like leading 0's in short sha that generated:

Error: invalid command options: 0.0.0-0010551 is not a valid semantic version: Numeric PreRelease version must not contain leading zeroes "0010551"
Usage:

could you rebase? probably that will generated new sha hopefully without leading 0s?

Oh, yes I noticed that once already ... didn't took the time to fix it at the time, now this should prevent it in the future: #1341

(also, PR rebased)

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:8358f73
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-8358f73
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-8358f73

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:8358f73 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-8358f73

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-8358f73
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[memodi]

thanks @jotak

/label qe-approved

[openshift-ci-robot]

@jotak: This pull request references NETOBSERV-1418 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Description

It's now impossible to change the namespace where netobserv components are deployed (driven by spec.namespace); if users want to do so, they need to delete then recreate the FlowCollector.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
• If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
• If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
• If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.