Downstream dockerfiles: manage BUILDVERSION, and some cleanup#1263
Downstream dockerfiles: manage BUILDVERSION, and some cleanup#1263jotak merged 3 commits intonetobserv:mainfrom
Conversation
jotak
commented
Mar 19, 2025
jotak
commented
- BUILDVERSION previsouly did not work. Add it as a global argument for all dockerfiles
- Remove COMMIT arg - it doesn't work, and actual upstream commit is anyway correctly labelled anyway as "vcs-ref" (not upstream-vcs-ref)
- Hence, remove upstream-vcs-ref
- Add 14d expiry on on-pushed images
- Bump versions in update-builds.sh
- BUILDVERSION previsouly did not work. Add it as a global argument for all dockerfiles - Remove COMMIT arg - it doesn't work, and actual upstream commit is anyway correctly labelled anyway as "vcs-ref" (not upstream-vcs-ref) - Hence, remove upstream-vcs-ref - Add 14d expiry on on-pushed images - Bump versions in update-builds.sh
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| - name: output-image | ||
| value: quay.io/redhat-user-workloads/ocp-network-observab-tenant/netobserv-operator/network-observability-operator-bundle:{{revision}} | ||
| - name: image-expires-after | ||
| value: 14d |
There was a problem hiding this comment.
@OlivierCazade I'm adding that because we generate a lot of builds and it surely is going to fill the quay repo :-/
idk if 14d is ok - I guess the point is that the last build has to be still there when it's time to release. If necessary maybe we can increase to 30d.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1263 +/- ##
==========================================
+ Coverage 62.71% 62.74% +0.03%
==========================================
Files 76 76
Lines 11551 11551
==========================================
+ Hits 7244 7248 +4
+ Misses 3846 3841 -5
- Partials 461 462 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
2 participants
