-
Notifications
You must be signed in to change notification settings - Fork 41
Updating containers digests references #1273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
export FLP_IMAGE_PULLSPEC='registry.redhat.io/network-observability/network-observability-flowlogs-pipeline-rhel9@sha256:c6c194d9f631f0b5233b1edfc52381d55fa0d64a84d9d354ec85e774be4f0ef6' | ||
# | ||
export CONSOLE_IMAGE_PULLSPEC='registry.redhat.io/network-observability/network-observability-console-plugin-rhel9@sha256:95b58585c1d9db9ad3b3e72d9263da91328a67a3cf2192b44bbee0c89d407687' | ||
export CONSOLE_IMAGE_PULLSPEC='registry.redhat.io/network-observability/network-observability-console-plugin-rhel9@sha256:7fa0b4ded5e30668be09fcd953a9912d9bc31d610419a281583d7f916694a49f' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OlivierCazade how do you pick those digest references? for instance I see these builds are not yet completed and they seem to be for unmerged PRs/commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I picked them from the last release snapshot on the konflux snapshot.
Are you sure they correspond to unmerged builds ? Only build from main branch should trigger new snapshot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for instance for consolePlugin is from PR #763
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @OlivierCazade is correct.
This konflux UI view is a bit misleading, what it shows in the left column is the last image built from the HEAD commit (ie. things that are merged) and on the right column is the last build, including unmerged builds. So the image on the left doesn't necessarily correspond to the build on the right.
You can verify that because PR image tags are prefixed with "on-pr-", like this one:
quay.io/redhat-user-workloads/ocp-network-observab-tenant/netobserv-operator/network-observability-operator-bundle:on-pr-867f4a431c4c231acc5c68752fcd4c1a7ff3edf0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moreover the fact that the images come from the release snapshot should be sufficient to be trusted, there's no way release snapshot could contained unmerged stuff, unless the whole thing being totally screwed up :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This konflux UI view is a bit misleading, what it shows in the left column is the last image built from the HEAD commit (ie. things that are merged) and on the right column is the last build, including unmerged builds.
ah, thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1273 +/- ##
==========================================
+ Coverage 62.66% 62.71% +0.04%
==========================================
Files 76 76
Lines 11599 11599
==========================================
+ Hits 7269 7274 +5
+ Misses 3865 3861 -4
+ Partials 465 464 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
/lgtm |
@@ -1,8 +1,8 @@ | |||
# Do not remove empty lines, they are there to reduce conflicts | |||
export OPERATOR_IMAGE_PULLSPEC='registry.redhat.io/network-observability/network-observability-rhel9-operator@sha256:304440234657a05d3fde85a780f23b29c80fcb7089b38c1b86b24dd799665c54' | |||
export OPERATOR_IMAGE_PULLSPEC='registry.redhat.io/network-observability/network-observability-rhel9-operator@sha256:e059192784283385687011b9fa4bb87094783d4530aa66b79168777666a6e2a0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one has changed since your PR :-)
export OPERATOR_IMAGE_PULLSPEC='registry.redhat.io/network-observability/network-observability-rhel9-operator@sha256:e059192784283385687011b9fa4bb87094783d4530aa66b79168777666a6e2a0' | |
export OPERATOR_IMAGE_PULLSPEC='registry.redhat.io/network-observability/network-observability-rhel9-operator@sha256:d8ff9f17ebbf1190632571aab60a7c9fbc7373acec63876e178ae09292805645' |
Description
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.