Do not use controller-runtime client when fetching cluster info

[jotak]

Description

Do not use controller-runtime client when fetching cluster info
Use live client instead; to avoid filling-up cache (CRDs can be big, in particular)

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mffiedler for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

❌ Patch coverage is 55.10204% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.15%. Comparing base (57ba20e) to head (efc0f32).
⚠️ Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/pkg/cluster/live_client.go	52.94%	8 Missing and 8 partials ⚠️
internal/pkg/cluster/cluster.go	64.28%	1 Missing and 4 partials ⚠️
internal/pkg/manager/manager.go	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2329      +/-   ##
==========================================
- Coverage   73.68%   73.15%   -0.53%     
==========================================
  Files          88       89       +1     
  Lines        9826     9877      +51     
==========================================
- Hits         7240     7226      -14     
- Misses       2146     2193      +47     
- Partials      440      458      +18     

Flag	Coverage Δ
unittests	73.15% <55.10%> (-0.53%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
internal/pkg/manager/manager.go	67.74% <0.00%> (ø)
internal/pkg/cluster/cluster.go	80.41% <64.28%> (-2.93%)	⬇️
internal/pkg/cluster/live_client.go	52.94% <52.94%> (ø)

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[OlivierCazade]

LGTM

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:01b5796
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-01b5796
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-01b5796

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:01b5796 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-sha-01b5796

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-sha-01b5796
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m