Adapt columns in frontend config with changes in plugin #835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotak
added
no-qe
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #835 +/- ##
==========================================
- Coverage 64.76% 64.73% -0.03%
==========================================
Files 75 75
Lines 10653 10653
==========================================
- Hits 6899 6896 -3
- Misses 3316 3318 +2
- Partials 438 439 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was generating an array such as [proto, undefined, undefined] for non-ICMP traffic, which doesn't play well with the visible column detection on frontend side. Instead, roll-back to using just a single field (IcmpType/IcmpCode) and the display implementation is handled on frontend side (it was already hard-coded anyway, so mixing generic+hard-coded stuff wasn't probably so relevant)
10 tasks
jpinsonneau
approved these changes
Nov 19, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on netobserv/network-observability-console-plugin#633