fix: Local patient not syncing after profile update#145
Merged
cbaker6 merged 1 commit intonetreconlab:mainfrom May 8, 2025
Merged
fix: Local patient not syncing after profile update#145cbaker6 merged 1 commit intonetreconlab:mainfrom
cbaker6 merged 1 commit intonetreconlab:mainfrom
Conversation
cbaker6
reviewed
May 8, 2025
Member
cbaker6
left a comment
There was a problem hiding this comment.
Looks good, but quick question/ask
Member
|
Technically, this should automatically update the patient in CareKitSample-ParseCareKit/OCKSample/Main/Profile/ProfileView.swift Lines 88 to 90 in f8e82a4 But, the way |
Member
|
Opened a related issue on CareKit: carekit-apple/CareKit#726 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the logic in
ProfileViewModel.saveProfile()to ensure that the local patient property stays in sync with the backend after saving.Specifically, it uses
store.updateAnyPatient(...)and casts the result back toOCKPatient, then assigns it toself.patientto trigger the willSet block and properly refresh local fields such asfirstName,lastName,birthday, etc.