Skip to content

refactor: Update to latest postgis #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cbaker6 merged 3 commits into from
Oct 14, 2025
Merged

refactor: Update to latest postgis #43

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b053d0
refactor: Update to latest postgis
cbaker6 Oct 14, 2025
eadffbf
Update Dockerfile.pgpool
cbaker6 Oct 14, 2025
df7414b
Update Dockerfile.pgpool
cbaker6 Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
FROM postgres:18-trixie

LABEL maintainer="HIPAA Postgres w/ PostGIS Project" \
org.opencontainers.image.description="PostGIS 3.6.0+dfsg-1.pgdg13+1 spatial database extension with PostgreSQL 18 trixie" \
org.opencontainers.image.description="PostGIS 3.6.0+dfsg-2.pgdg13+1 spatial database extension with PostgreSQL 18 trixie" \
org.opencontainers.image.source="https://github.com/netreconlab/hipaa-postgres/"

ENV POSTGIS_MAJOR=3
ENV POSTGIS_VERSION=3.6.0+dfsg-1.pgdg13+1
ENV POSTGIS_VERSION=3.6.0+dfsg-2.pgdg13+1
Copy link

@coderabbitai coderabbitai bot Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Version bump looks right—confirm availability.

Ensure apt.postgresql.org for trixie has postgresql-18-postgis-3 at 3.6.0+dfsg-2.pgdg13+1 to keep builds green.

🌐 Web query:

Does apt.postgresql.org provide package "postgresql-18-postgis-3" with version "3.6.0+dfsg-2.pgdg13+1" for Debian trixie (Debian 13)?

💡 Result:

No. apt.postgresql.org (the PGDG pool) provides postgresql-18-postgis-3 for trixie as 3.6.0+dfsg-1.pgdg13+1 (see the PGDG pool listing). The 3.6.0+dfsg-2 build appears in Debian/unpacked suites (sid/forky) per packages.debian.org, not as 3.6.0+dfsg-2.pgdg13+1 on apt.postgresql.org for trixie. [1][2]

Sources:

  • apt.postgresql.org pool listing showing postgresql-18-postgis-3_3.6.0+dfsg-1.pgdg13+1. [1]
  • Debian package search / packages.debian.org showing 3.6.0+dfsg-2 in unstable/testing (not PGDG trixie). [2]

Specify available PostGIS version for Debian trixie
apt.postgresql.org pool for trixie only provides postgresql-18-postgis-3 at 3.6.0+dfsg-1.pgdg13+1, not 3.6.0+dfsg-2.pgdg13+1—adjust ENV POSTGIS_VERSION to 3.6.0+dfsg-1.pgdg13+1 to keep builds green! Plus Ultra!

🤖 Prompt for AI Agents 
In Dockerfile around line 8, ENV POSTGIS_VERSION is set to 3.6.0+dfsg-2.pgdg13+1
which is not available in the Debian trixie apt.postgresql.org pool; update the
value to the available package version 3.6.0+dfsg-1.pgdg13+1 to match the
repository and ensure builds succeed, then rebuild/test the image to verify the
package resolves.

ENV POSTGRES_INITDB_ARGS="--data-checksums"

RUN apt-get update \
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile.pgpool
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
FROM postgres:18-trixie

LABEL maintainer="HIPAA Postgres w/ PostGIS Project" \
org.opencontainers.image.description="PostGIS 3.5.2+dfsg-1.pgdg110+1 spatial database extension and PGPool with PostgreSQL 18 trixie" \
org.opencontainers.image.description="PostGIS 3.5.2+dfsg-2.pgdg110+1 spatial database extension and PGPool with PostgreSQL 18 trixie" \
Copy link

@coderabbitai coderabbitai bot Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Metadata mismatch: label shows 3.5.2/pgdg110, env uses 3.6.0/pgdg13. Fix to stay heroic.

Align the description with the actual version/distro to avoid confusion.

Apply this diff:

-      org.opencontainers.image.description="PostGIS 3.5.2+dfsg-2.pgdg110+1 spatial database extension and PGPool with PostgreSQL 18 trixie" \
+      org.opencontainers.image.description="PostGIS 3.6.0+dfsg-2.pgdg13+1 spatial database extension and PGPool with PostgreSQL 18 trixie" \
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
org.opencontainers.image.description="PostGIS 3.5.2+dfsg-2.pgdg110+1 spatial database extension and PGPool with PostgreSQL 18 trixie" \
org.opencontainers.image.description="PostGIS 3.6.0+dfsg-2.pgdg13+1 spatial database extension and PGPool with PostgreSQL 18 trixie" \
🤖 Prompt for AI Agents 
In Dockerfile.pgpool around line 4, the org.opencontainers.image.description
label states PostGIS 3.5.2/pgdg110 while the image/environment uses PostGIS
3.6.0/pgdg13; update the description label to accurately reflect the actual
PostGIS version and distro (e.g., "PostGIS 3.6.0+dfsg-... pgdg13") so metadata
matches the image (alternatively, if the intended target is 3.5.2/pgdg110,
change the environment/version to match the label), ensuring the label text
exactly matches the real version and package identifier.

org.opencontainers.image.source="https://github.com/netreconlab/hipaa-postgres/"

ENV POSTGIS_MAJOR=3
ENV POSTGIS_VERSION=3.6.0+dfsg-1.pgdg13+1
ENV POSTGIS_VERSION=3.6.0+dfsg-2.pgdg13+1
Copy link

@coderabbitai coderabbitai bot Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

POSTGIS_VERSION bump looks solid—let’s verify the package exists.

Confirm the package/version is published for trixie to ensure reproducible builds.

🌐 Web query:

Confirm availability of "postgresql-18-postgis-3" version "3.6.0+dfsg-2.pgdg13+1" in the PGDG trixie repository.

💡 Result:

I could not find evidence that the exact package version "3.6.0+dfsg-2.pgdg13+1" exists in the PGDG trixie repository. PGDG/apt listings show trixie packages with version "3.6.0+dfsg-1.pgdg13+1" for postgresql-18-postgis-3. [1] The Debian tracker shows postgis 3.6.0+dfsg-2 was accepted into Debian unstable (source) but without the "pgdg13+1" PGDG build suffix. [2]

Sources:

  • PGDG package listing showing trixie entry as 3.6.0+dfsg-1.pgdg13+1. [1]
  • Debian tracker / news entry for postgis 3.6.0+dfsg-2 (accepted into unstable). [2]

Update Dockerfile.pgpool ENV POSTGIS_VERSION to 3.6.0+dfsg-1.pgdg13+1
The PGDG trixie repo only provides that version—3.6.0+dfsg-2.pgdg13+1 will not be found. Plus Ultra!

🤖 Prompt for AI Agents 
In Dockerfile.pgpool around line 8, the POSTGIS_VERSION ENV is set to
3.6.0+dfsg-2.pgdg13+1 which does not exist in the PGDG trixie repo; change the
value to 3.6.0+dfsg-1.pgdg13+1 so the package can be resolved and builds succeed
— update the ENV line accordingly and run a quick build to verify the image
pulls the correct PostGIS package.

ENV POSTGRES_INITDB_ARGS="--data-checksums"

RUN apt-get update \
Expand Down