fix: allow testing-framework ^9.0 for TYPO3 v14 compatibility#1
fix: allow testing-framework ^9.0 for TYPO3 v14 compatibility#1
Conversation
testing-framework 8.x requires typo3/cms-backend 12.*.*@dev || 13.*.*@dev, which conflicts with dev-main (now v14). testing-framework 9.x supports 13.*.*@dev || 14.*.*@dev. Allowing both ranges lets composer resolve the correct version based on the TYPO3 core version being tested. Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves dependency conflicts encountered when testing against TYPO3 Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates composer.json to allow typo3/testing-framework version ^9.0 alongside ^8.0.9. This is a necessary change to support testing against TYPO3 v14, which requires the newer version of the testing framework. The change is correct and allows Composer to resolve the appropriate dependency version based on the TYPO3 version being used. The implementation is sound and I have no further comments.
Note: Security Review has been skipped due to the limited scope of the PR.
Summary
typo3/testing-framework ^9.0alongside^8.0.9to fix composer dependency resolution when testing against TYPO3dev-main(v14)Problem
The
tests-mainandcode-qualityworkflows fail with:testing-framework 8.x only supports TYPO3 12/13. TYPO3
dev-mainis now v14, which requires testing-framework 9.x.Fix
Change constraint from
"^8.0.9"to"^8.0.9 || ^9.0". Composer resolves the correct version automatically:Verified locally:
composer update --dry-runsucceeds and lockstypo3/testing-framework 9.4.0.Note: testing-framework 9.x requires PHP 8.2+, but the
tests-mainworkflow already only runs on PHP 8.2/8.3.