Skip to content

fix: allow testing-framework ^9.0 for TYPO3 v14 compatibility#1

Closed
CybotTM wants to merge 1 commit intomainfrom
fix/testing-framework-v9
Closed

fix: allow testing-framework ^9.0 for TYPO3 v14 compatibility#1
CybotTM wants to merge 1 commit intomainfrom
fix/testing-framework-v9

Conversation

@CybotTM
Copy link
Member

@CybotTM CybotTM commented Mar 7, 2026

Summary

  • Allow typo3/testing-framework ^9.0 alongside ^8.0.9 to fix composer dependency resolution when testing against TYPO3 dev-main (v14)

Problem

The tests-main and code-quality workflows fail with:

Your requirements could not be resolved to an installable set of packages.
  - typo3/testing-framework[8.0.9, ..., 8.3.1] require typo3/cms-backend 12.*.*@dev || 13.*.*@dev
    -> found typo3/cms-backend[...] but it conflicts with your root composer.json require (dev-main).

testing-framework 8.x only supports TYPO3 12/13. TYPO3 dev-main is now v14, which requires testing-framework 9.x.

Fix

Change constraint from "^8.0.9" to "^8.0.9 || ^9.0". Composer resolves the correct version automatically:

  • 8.x when testing against TYPO3 12.4 or 13.x
  • 9.x when testing against TYPO3 dev-main (v14)

Verified locally: composer update --dry-run succeeds and locks typo3/testing-framework 9.4.0.

Note: testing-framework 9.x requires PHP 8.2+, but the tests-main workflow already only runs on PHP 8.2/8.3.

testing-framework 8.x requires typo3/cms-backend 12.*.*@dev || 13.*.*@dev,
which conflicts with dev-main (now v14). testing-framework 9.x supports
13.*.*@dev || 14.*.*@dev. Allowing both ranges lets composer resolve the
correct version based on the TYPO3 core version being tested.

Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves dependency conflicts encountered when testing against TYPO3 dev-main (v14) by expanding the allowed versions for the typo3/testing-framework package. This change ensures that Composer can correctly resolve dependencies, allowing the project to be tested against both older TYPO3 versions (12.4/13.x) and the upcoming v14.

Highlights

  • Dependency Update: Updated the typo3/testing-framework dependency constraint in composer.json to allow version ^9.0 alongside ^8.0.9.
  • TYPO3 v14 Compatibility: Ensured compatibility with TYPO3 dev-main (v14) by enabling the use of typo3/testing-framework 9.x, resolving previous composer dependency resolution failures.
Changelog
  • composer.json
    • Updated the typo3/testing-framework dependency to include version ^9.0 for TYPO3 v14 compatibility.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates composer.json to allow typo3/testing-framework version ^9.0 alongside ^8.0.9. This is a necessary change to support testing against TYPO3 v14, which requires the newer version of the testing framework. The change is correct and allows Composer to resolve the appropriate dependency version based on the TYPO3 version being used. The implementation is sound and I have no further comments.

Note: Security Review has been skipped due to the limited scope of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant