fix(ci): use PR author instead of actor for auto-merge check #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflow was using github.actor which changes when someone else pushes to a dependabot/renovate branch (e.g., to fix conflicts). Using github.event.pull_request.user.login ensures we check the actual PR author regardless of who triggered the synchronize event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
github.actortogithub.event.pull_request.user.loginProblem
The workflow was using
github.actorwhich reflects who triggered the event, not the PR author:openedevent →github.actor = dependabot[bot]synchronizeevent (after someone pushes) →github.actor = <that user>This caused PR #14 to skip auto-merge.
Solution
Use
github.event.pull_request.user.loginwhich always reflects the original PR author.Test plan