fix: use 'tools' parent for v13 compatibility#74
Conversation
The 'admin' module group was introduced in TYPO3 v14. On v13, only 'tools' exists as the admin tools parent module. Using 'admin' causes the LLM modules to silently fail to register on v13. Change to 'tools' which works on both versions: - v13: 'tools' exists natively - v14: 'tools' is an alias for 'admin' Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical compatibility issue in the backend module registration for TYPO3. By changing the parent module from 'admin' to 'tools', the module will now correctly appear and function in both TYPO3 v13 and v14 environments, addressing a previous silent failure to register on v13 due to the absence of the 'admin' group. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Automated approval for solo maintainer project
This PR has passed all automated quality gates:
- ✅ Static analysis (PHPStan)
- ✅ Code style (PHP-CS-Fixer)
- ✅ Unit & functional tests
- ✅ Security scanning
- ✅ Dependency review
See SECURITY_CONTROLS.md for compensating controls documentation.
|
Thanks for your first pull request! We are excited to have you contribute. |
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a compatibility issue for TYPO3 v13 by changing the backend module's parent from 'admin' to 'tools'. The change is well-contained, and the updated comments clearly explain the rationale for compatibility across both TYPO3 v13 and v14. The implementation is straightforward and appears correct.
There was a problem hiding this comment.
Pull request overview
Adjusts TYPO3 backend module registration to be compatible with both supported TYPO3 versions (v13 and v14) by using a parent module identifier that exists across versions.
Changes:
- Change the main module’s
parentfromadmin(v14-only) totools(works on v13 and v14). - Update module registration docblock to document the v13/v14 compatibility rationale.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… RTE - Add seed-pages.sql with demo page tree (4 pages, 5 RTE content elements) - Add seed-pages host command for manual re-seeding - Auto-import seed data (pages + Ollama config) in install scripts - Auto-activate cowriter RTE preset via page.tsconfig (TYPO3 standard) - Update Makefile: use ollama-pull target, handle errors gracefully Upstream fixes released for dependency issues discovered during testing: - nr_vault v0.4.1: XLF label keys + module parent v13 compat (netresearch/t3x-nr-vault#92) - nr_llm v0.2.2: module parent v13 compat (netresearch/t3x-nr-llm#74) Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
… RTE - Add seed-pages.sql with demo page tree (4 pages, 5 RTE content elements) - Add seed-pages host command for manual re-seeding - Auto-import seed data (pages + Ollama config) in install scripts - Auto-activate cowriter RTE preset via page.tsconfig (TYPO3 standard) - Update Makefile: use ollama-pull target, handle errors gracefully Upstream fixes released for dependency issues discovered during testing: - nr_vault v0.4.1: XLF label keys + module parent v13 compat (netresearch/t3x-nr-vault#92) - nr_llm v0.2.2: module parent v13 compat (netresearch/t3x-nr-llm#74) Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
… RTE - Add seed-pages.sql with demo page tree (4 pages, 5 RTE content elements) - Add seed-pages host command for manual re-seeding - Auto-import seed data (pages + Ollama config) in install scripts - Auto-activate cowriter RTE preset via page.tsconfig (TYPO3 standard) - Update Makefile: use ollama-pull target, handle errors gracefully Upstream fixes released for dependency issues discovered during testing: - nr_vault v0.4.1: XLF label keys + module parent v13 compat (netresearch/t3x-nr-vault#92) - nr_llm v0.2.2: module parent v13 compat (netresearch/t3x-nr-llm#74) Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
Summary
parent => 'admin'which only exists in TYPO3 v14admingroup doesn't exist — modules with a non-existent parent silently fail to registerparent => 'tools'which works on both versions:toolsexists natively as the admin tools grouptoolsis an alias for the newadmingroupContext
composer.jsondeclares^13.4 || ^14.0support, but the module registration only worked on v14.Same issue was fixed in nr_vault: netresearch/t3x-nr-vault#92
Test plan