Skip to content

fix: use 'tools' parent for v13 compatibility#74

Merged
CybotTM merged 1 commit intomainfrom
fix/module-parent-v13-compat
Mar 1, 2026
Merged

fix: use 'tools' parent for v13 compatibility#74
CybotTM merged 1 commit intomainfrom
fix/module-parent-v13-compat

Conversation

@CybotTM
Copy link
Member

@CybotTM CybotTM commented Mar 1, 2026

Summary

  • Fix backend module using parent => 'admin' which only exists in TYPO3 v14
  • On v13, the admin group doesn't exist — modules with a non-existent parent silently fail to register
  • Changed to parent => 'tools' which works on both versions:
    • v13: tools exists natively as the admin tools group
    • v14: tools is an alias for the new admin group

Context

composer.json declares ^13.4 || ^14.0 support, but the module registration only worked on v14.

Same issue was fixed in nr_vault: netresearch/t3x-nr-vault#92

Test plan

  • Install nr_llm on TYPO3 v14 — LLM module appears under Admin Tools
  • Install nr_llm on TYPO3 v13 — LLM module appears under Admin Tools
  • All submodules (Providers, Models, Configurations, Tasks, Wizard) accessible from docheader dropdown

The 'admin' module group was introduced in TYPO3 v14. On v13, only
'tools' exists as the admin tools parent module. Using 'admin' causes
the LLM modules to silently fail to register on v13.

Change to 'tools' which works on both versions:
- v13: 'tools' exists natively
- v14: 'tools' is an alias for 'admin'

Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
Copilot AI review requested due to automatic review settings March 1, 2026 08:26
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical compatibility issue in the backend module registration for TYPO3. By changing the parent module from 'admin' to 'tools', the module will now correctly appear and function in both TYPO3 v13 and v14 environments, addressing a previous silent failure to register on v13 due to the absence of the 'admin' group.

Highlights

  • TYPO3 Compatibility Fix: Updated the backend module registration to use 'tools' as the parent module instead of 'admin' to ensure compatibility with both TYPO3 v13 and v14, resolving a silent registration failure on v13.
Changelog
  • Configuration/Backend/Modules.php
    • Updated the parent module for the 'nrllm' backend module from 'admin' to 'tools'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added configuration Configuration changes backend TYPO3 backend changes labels Mar 1, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval for solo maintainer project

This PR has passed all automated quality gates:

  • ✅ Static analysis (PHPStan)
  • ✅ Code style (PHP-CS-Fixer)
  • ✅ Unit & functional tests
  • ✅ Security scanning
  • ✅ Dependency review

See SECURITY_CONTROLS.md for compensating controls documentation.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2026

Thanks for your first pull request! We are excited to have you contribute.
A maintainer will review your PR soon. Please ensure all CI checks pass.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses a compatibility issue for TYPO3 v13 by changing the backend module's parent from 'admin' to 'tools'. The change is well-contained, and the updated comments clearly explain the rationale for compatibility across both TYPO3 v13 and v14. The implementation is straightforward and appears correct.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts TYPO3 backend module registration to be compatible with both supported TYPO3 versions (v13 and v14) by using a parent module identifier that exists across versions.

Changes:

  • Change the main module’s parent from admin (v14-only) to tools (works on v13 and v14).
  • Update module registration docblock to document the v13/v14 compatibility rationale.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@CybotTM CybotTM added this pull request to the merge queue Mar 1, 2026
Merged via the queue into main with commit f3ee210 Mar 1, 2026
80 checks passed
@CybotTM CybotTM deleted the fix/module-parent-v13-compat branch March 1, 2026 08:39
CybotTM added a commit to netresearch/t3x-cowriter that referenced this pull request Mar 1, 2026
… RTE

- Add seed-pages.sql with demo page tree (4 pages, 5 RTE content elements)
- Add seed-pages host command for manual re-seeding
- Auto-import seed data (pages + Ollama config) in install scripts
- Auto-activate cowriter RTE preset via page.tsconfig (TYPO3 standard)
- Update Makefile: use ollama-pull target, handle errors gracefully

Upstream fixes released for dependency issues discovered during testing:
- nr_vault v0.4.1: XLF label keys + module parent v13 compat (netresearch/t3x-nr-vault#92)
- nr_llm v0.2.2: module parent v13 compat (netresearch/t3x-nr-llm#74)

Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
CybotTM added a commit to netresearch/t3x-cowriter that referenced this pull request Mar 1, 2026
… RTE

- Add seed-pages.sql with demo page tree (4 pages, 5 RTE content elements)
- Add seed-pages host command for manual re-seeding
- Auto-import seed data (pages + Ollama config) in install scripts
- Auto-activate cowriter RTE preset via page.tsconfig (TYPO3 standard)
- Update Makefile: use ollama-pull target, handle errors gracefully

Upstream fixes released for dependency issues discovered during testing:
- nr_vault v0.4.1: XLF label keys + module parent v13 compat (netresearch/t3x-nr-vault#92)
- nr_llm v0.2.2: module parent v13 compat (netresearch/t3x-nr-llm#74)

Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
CybotTM added a commit to netresearch/t3x-cowriter that referenced this pull request Mar 2, 2026
… RTE

- Add seed-pages.sql with demo page tree (4 pages, 5 RTE content elements)
- Add seed-pages host command for manual re-seeding
- Auto-import seed data (pages + Ollama config) in install scripts
- Auto-activate cowriter RTE preset via page.tsconfig (TYPO3 standard)
- Update Makefile: use ollama-pull target, handle errors gracefully

Upstream fixes released for dependency issues discovered during testing:
- nr_vault v0.4.1: XLF label keys + module parent v13 compat (netresearch/t3x-nr-vault#92)
- nr_llm v0.2.2: module parent v13 compat (netresearch/t3x-nr-llm#74)

Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend TYPO3 backend changes configuration Configuration changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants