Skip to content

feat: add skill validation CI job #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CybotTM merged 1 commit into from
Feb 25, 2026
Merged

feat: add skill validation CI job #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,7 @@ jobs:
severity: error
env:
SHELLCHECK_OPTS: -x

validate:
name: Skill Validation
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validate job does not explicitly define permissions. When calling a reusable workflow, permissions are not inherited by default from the caller workflow. If the reusable workflow needs to access repository contents or other resources, you may need to explicitly pass permissions using the 'permissions' key at the job level, or ensure the reusable workflow has 'permissions: read-all' or specific permissions defined. Verify whether the netresearch/skill-repo-skill validate.yml workflow requires any specific permissions.

Suggested change
name: Skill Validation
name: Skill Validation
permissions:
contents: read

Copilot uses AI. Check for mistakes.
uses: netresearch/skill-repo-skill/.github/workflows/validate.yml@main
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reusable workflow reference uses @main which is a mutable branch reference. All other action references in this repository use pinned commit SHAs for security (e.g., @de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2). Using @main allows the referenced workflow to change without your knowledge, potentially introducing malicious code or breaking changes. Consider pinning to a specific commit SHA or at minimum a tagged version, following the established pattern in this codebase.

Suggested change
uses: netresearch/skill-repo-skill/.github/workflows/validate.yml@main
uses: netresearch/skill-repo-skill/.github/workflows/validate.yml@v1

Copilot uses AI. Check for mistakes.