Conversation
Summary of ChangesHello @CybotTM, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates new continuous integration (CI) workflows to enforce code style and best practices. By adding markdownlint and shellcheck, the project aims to maintain higher quality documentation and scripts, ensuring that all contributions adhere to predefined standards before being merged into the main branch. Highlights
Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a configuration file for markdownlint, disabling three specific rules. My review suggests that two of these rules, MD033 (inline HTML) and MD041 (first line heading), should be re-enabled to maintain higher standards for markdown quality, as their disabling does not seem justified by the current content. It's also worth noting that the pull request, titled 'add lint CI', appears incomplete as it only contains this configuration file and not the actual CI workflow for markdownlint or the mentioned shellcheck.
|
Closing: superseded by #6 which included the full lint workflow (markdown + yamllint + shellcheck). |
Add markdownlint and shellcheck CI for pull requests and main branch pushes.