Add support for packetInterval and packetSpace to configure sampling rate #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What a coincidence that you implemented this recently! I was just looking into this issue with the Nokia devices. I tested your branch (at bbdfb9e) and it works as expected with the Nokia-IPFIX I have at hand. |
Member
|
Will have a look. Thank you for the suggestion
please keep in mind that these are public functions that can be used by other tools importing the library. |
Author
My bad, I've restored the deleted functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #440
Implement sampling rate calculation based on PacketSpace and PacketInterval fields.
Remove unused methods.